20 Aug 02:23
Export MIDI refined, NoteTrack selection behavior changed
From: Greg Williams <gswillia <at> users.sourceforge.net>
Subject: Export MIDI refined, NoteTrack selection behavior changed
Newsgroups: gmane.comp.audio.audacity.devel
Date: 2008-08-20 00:24:59 GMT
Subject: Export MIDI refined, NoteTrack selection behavior changed
Newsgroups: gmane.comp.audio.audacity.devel
Date: 2008-08-20 00:24:59 GMT
With my most recent commit, I've incorporated a bunch of suggestions into the "Export MIDI" option, and I've changed the way that Audacity shows that a portion of a NoteTrack has been selected.
The following are the suggestions received for Export MIDI (thanks, Gale!):
>Let the user just enter the filename when saving, which then exports as *.mid. This is analogous with normal practice exporting audio
Done.
>Allow the *.midi extension as well, without throwing a warning
Done. For consistency, I also allowed *.midi files to be imported (this was disallowed before, with an "Incorrect Filetype" error message).
>When the "saving with unrecognised file extension" warning occurs, and you choose no, send the user back to the "Export MIDI As:" dialogue.
Done.
>Like other file dialogues, the window includes zip files even when a specific filter such as *.mid is chosen. Shouldn't we exclude these from being considered a folder, like we did in 1.2.6?
I couldn't figure this one out, but it seems to apply to most file dialogues, so at least it's consistent for now, and when it's fixed on the other file dialogues, I'll look at the code that excludes zip files and transfer it over.
>When only a MIDI is on screen, normal Export functions should be greyed out.
To fix this, I changed instances of TracksExistFlag in Export to WaveTracksExistFlag, and TracksSelectedFlag in Export Selection to WaveTracksSelectedFlag, since I'm fairly certain that the only types of tracks to consider for export are Wave, Note, and Label. If this is incorrect, please let me know and I can go back and fix it. (I left Export Labels and Export Multiple alone.)
>Undoing cut/copy/paste in MIDI tracks seems to empty the track of data, with no way of getting it back (Redo does not help).
Sure enough, this was a bug I had fixed, and I cannot replicate it on my machine. I checked the CVS repository, and the fix seems to be in there. If an update doesn't fix this bug, please let me know and I'll look into it again.
Also, when a portion of a NoteTrack is selected, the old behavior was to color the inside of the notes white. This has been replaced with keeping the color of the notes intact, and instead changing the background color of the selected portion of the NoteTrack (which matches the background color of a selected WaveTrack quite nicely, if I do say so myself). Although it was originally planned to change the color of MIDI Channel 10 due to similarity, the new background turns out not to be similar enough to warrant a change to the color of the channel. However, if anyone feels otherwise (perhaps taking into consideration colorblind users), let me know and I can change things around.
As usual, if anything breaks, USE_MIDI can be turned off in the config files until a more permanent solution is found.
Thanks for all feedback.
-Greg
The following are the suggestions received for Export MIDI (thanks, Gale!):
>Let the user just enter the filename when saving, which then exports as *.mid. This is analogous with normal practice exporting audio
Done.
>Allow the *.midi extension as well, without throwing a warning
Done. For consistency, I also allowed *.midi files to be imported (this was disallowed before, with an "Incorrect Filetype" error message).
>When the "saving with unrecognised file extension" warning occurs, and you choose no, send the user back to the "Export MIDI As:" dialogue.
Done.
>Like other file dialogues, the window includes zip files even when a specific filter such as *.mid is chosen. Shouldn't we exclude these from being considered a folder, like we did in 1.2.6?
I couldn't figure this one out, but it seems to apply to most file dialogues, so at least it's consistent for now, and when it's fixed on the other file dialogues, I'll look at the code that excludes zip files and transfer it over.
>When only a MIDI is on screen, normal Export functions should be greyed out.
To fix this, I changed instances of TracksExistFlag in Export to WaveTracksExistFlag, and TracksSelectedFlag in Export Selection to WaveTracksSelectedFlag, since I'm fairly certain that the only types of tracks to consider for export are Wave, Note, and Label. If this is incorrect, please let me know and I can go back and fix it. (I left Export Labels and Export Multiple alone.)
>Undoing cut/copy/paste in MIDI tracks seems to empty the track of data, with no way of getting it back (Redo does not help).
Sure enough, this was a bug I had fixed, and I cannot replicate it on my machine. I checked the CVS repository, and the fix seems to be in there. If an update doesn't fix this bug, please let me know and I'll look into it again.
Also, when a portion of a NoteTrack is selected, the old behavior was to color the inside of the notes white. This has been replaced with keeping the color of the notes intact, and instead changing the background color of the selected portion of the NoteTrack (which matches the background color of a selected WaveTrack quite nicely, if I do say so myself). Although it was originally planned to change the color of MIDI Channel 10 due to similarity, the new background turns out not to be similar enough to warrant a change to the color of the channel. However, if anyone feels otherwise (perhaps taking into consideration colorblind users), let me know and I can change things around.
As usual, if anything breaks, USE_MIDI can be turned off in the config files until a more permanent solution is found.
Thanks for all feedback.
-Greg
------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________ audacity-devel mailing list audacity-devel <at> lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/audacity-devel
RSS Feed