Davy Durham | 12 Apr 06:40

Re: Markers in wave files

Okay.. this the 3rd time I've sent this email but haven't seen it show 
up on the list.. What is/has-been the deal?

My original question:   Does this look to be an acceptable patch?  If 
so, when might it show up in the CVS tree?

Davy Durham wrote:

> Hi.. I have checked out the sourcecode to libaudiofile and make added 
> support for reading and writing cues in the wave format.
>
> Wave already supported reading cue positions, but didn't read cue 
> names. The prescribed way of storing cue names in the format is with a 
> 'list'/'adtl' chunk according to 
> http://www.borg.com/~jglatt/tech/wave.htm .
>
> I added this reading support to wave.c  and also adding writing 
> marks/cues to wavewrite.c
>
> I have attached a patch... I have tested it with my audio editing 
> application and am able to load and save cues succefully.  Also, I 
> just threw in reading mark/cue comments since it was just a simple 
> added case to one section of code.  To write the comments would also 
> be pretty easy, but I'm not using comments so I didn't do it.  If you 
> want me to I could.
>
> I pretty much followed the way things were done according to the rest 
> of the wave I/O code.
>
> I'm wondering, that if the patch is accepted when the next release of 
> libaudiofile is scheduled for?  Because I want to debut my application 
> to the community in probably a month or so, and it would be nice if 
> the distro packagers already had packages for the new version.  It's 
> not as if my application won't run, it's just that cue/marks won't be 
> preserved.  Are the query methods capable of indicating if cue's are 
> load/save-able for a particular format?
>
> On that note, I didn't update any of the afQuery-ing functions to 
> return if mark/cue I/O support was implemented or not.  I wasn't quite 
> sure how all that worked and even IF the query functions are used for 
> determining that sort of detail about a format's support.  If that 
> needs to be updated in the code either let me know and I can add it to 
> the patch, or you can do it yourself since you probably know better 
> how to add it.
>
> -- Davy
>
>


Gmane