11 May 18:13
Re: [C. Scott Ananian] Bug#167527: zinf: Bad URL parsing.
Kristian Kvilekval <kris <at> cs.ucsb.edu>
2003-05-11 16:13:43 GMT
2003-05-11 16:13:43 GMT
This is fixed in CVS. While doing the fix, I noticed that we seem to have several implementations of http stuff in zinf (see io/http/httpinput.cpp, lib/http/src/Http.cpp) Since this code is remarkable similar, yet has different capabilities (one supports ipv6), httpinput supports icecast extras. Does anybody know of a good c++ library for http handling? I would like to consolidate the two implementations (they both could use some cleaning up). On Thu, 2003-05-08 at 01:03, Andreas Rottmann wrote: > I just got this bugreport, maybe someone can look into it - seems easy > to fix... > > > ______________________________________________________________________ > > From: C. Scott Ananian <cananian <at> lm.lcs.mit.edu> > To: Debian Bug Tracking System <167527 <at> bugs.debian.org> > Subject: Bug#167527: zinf: Bad URL parsing. > Date: 07 May 2003 19:20:49 -0400 > > X-From-Line: debbugs <at> master.debian.org Thu May 08 09:45:23 2003 > Return-path: <debbugs <at> master.debian.org> > Envelope-to: andy <at> localhost > Delivery-date: Thu, 08 May 2003 09:45:23 +0200 > Received: from localhost ([127.0.0.1] ident=andy) > by alice.rhinosaur.lan with esmtp (Exim 3.36 #1 (Debian)) > id 19Dg5j-0000B6-00 > for <andy <at> localhost>; Thu, 08 May 2003 09:45:23 +0200 > X-Flags: 0000 > Delivered-To: GMX delivery to a.rottmann <at> gmx.at > Received: from pop.gmx.net [213.165.65.60] > by localhost with POP3 (fetchmail-6.2.0) > for andy <at> localhost (single-drop); Thu, 08 May 2003 09:45:23 +0200 (CEST) > Received: (qmail 22319 invoked by uid 65534); 7 May 2003 23:39:28 -0000 > Received: from master.debian.org (EHLO master.debian.org) (146.82.138.7) > by mx0.gmx.net (mx025-rz3) with SMTP; 08 May 2003 01:39:28 +0200 > Received: from debbugs by master.debian.org with local (Exim 3.12 1 > (Debian)) > id 19DYPK-00085z-00; Wed, 07 May 2003 18:33:06 -0500 > X-Loop: owner <at> bugs.debian.org > Subject: Bug#167527: zinf: Bad URL parsing. > Reply-To: "C. Scott Ananian" <cananian <at> lm.lcs.mit.edu>, > 167527 <at> bugs.debian.org > Resent-From: "C. Scott Ananian" <cananian <at> lm.lcs.mit.edu> > Original-Sender: "C. Scott Ananian" <cananian <at> skiffserv.dyndns.org> > Resent-To: debian-bugs-dist <at> lists.debian.org > Resent-CC: Andreas Rottmann <rotty <at> debian.org>, zinf <at> packages.qa.debian.org > Resent-Date: Wed, 07 May 2003 23:33:05 GMT > Resent-Message-ID: <handler.167527.B167527.105234965225249 <at> bugs.debian.org> > X-Debian-PR-Message: report 167527 > X-Debian-PR-Package: zinf > Received: via spool by 167527-submit <at> bugs.debian.org > id=B167527.105234965225249 > (code B ref 167527); Wed, 07 May 2003 23:33:05 GMT > Received: (at 167527) by bugs.debian.org; 7 May 2003 23:20:52 +0000 > Received: from 24-6-231.wireless.lcs.mit.edu (skiffserv.dyndns.org) > [18.24.6.231] > by master.debian.org with esmtp (Exim 3.12 1 (Debian)) > id 19DYDS-0006Yx-00; Wed, 07 May 2003 18:20:50 -0500 > Received: from cananian by skiffserv.dyndns.org with local (Exim 3.36 #1 > (Debian)) > id 19DYDR-0000lH-00 > for <167527 <at> bugs.debian.org>; Wed, 07 May 2003 19:20:49 -0400 > From: "C. Scott Ananian" <cananian <at> lm.lcs.mit.edu> > To: Debian Bug Tracking System <167527 <at> bugs.debian.org> > Message-Id: <E19DYDR-0000lH-00 <at> skiffserv.dyndns.org> > Sender: "C. Scott Ananian" <cananian <at> skiffserv.dyndns.org> > Date: Wed, 07 May 2003 19:20:49 -0400 > Delivered-To: 167527 <at> bugs.debian.org > Resent-Sender: Debian BTS <debbugs <at> master.debian.org> > X-GMX-Antivirus: -1 (not scanned, may not use virus scanner) > X-Spam-Status: No, hits=-8.5 required=5.0 > tests=BAYES_01,BUGS_DEBIAN_ORG,DEBIAN_BTS_BUG,X_LOOP > autolearn=ham version=2.53 > X-Spam-Level: > X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) > Lines: 42 > Xref: alice.rhinosaur.lan private:4142 > MIME-Version: 1.0 > > *** Please type your report below this line *** > The URL parsing is done in httpinput.cpp with the following line: > iRet = sscanf(m_path, " http: //%[^:/]:%d", szHostName, &iPort); > Bcc: "C. Scott Ananian" <cananian <at> lm.lcs.mit.edu> > X-Mailer: reportbug 2.10.1 > Date: Wed, 07 May 2003 19:20:48 -0400 > > Package: zinf > Version: 2.2.2+cvs20030131+dp1-4 > Followup-For: Bug #167527 > > This code is obviously broken in that it *requires* the *optional* port field > in the URL. I didn't obviously see where the extra colon in the original > reporter's problem URL would get misparsed, but the URL handling is > sloppy at best. It should be rewritten to conform with the RFCs. > --scott > > -- System Information: > Debian Release: testing/unstable > Architecture: i386 > Kernel: Linux skiffserv 2.4.17 #1 Wed Sep 18 20:04:31 EDT 2002 i686 > Locale: LANG=C, LC_CTYPE=C > > Versions of packages zinf depends on: > ii libc6 2.3.1-17 GNU C Library: Shared libraries an > ii libgcc1 1:3.3-0pre7 GCC support library > ii libgdk-pixbuf2 0.22.0-2.0.1 The GdkPixBuf image library, gtk+ > ii libglib1.2 1.2.10-ximian.2 The GLib library of C routines > ii libgtk1.2 1.2.10-ximian.21 The GIMP Toolkit set of widgets fo > ii libid3-3.8.3 3.8.3-1 Library for manipulating ID3v1 and > ii libmusicbrainz2 2.0.1-1 Second generation incarnation of t > ii libstdc++5 1:3.3-0pre7 The GNU Standard C++ Library v3 > ii libttf2 1.4pre.20011029-1 FreeType 1, The FREE TrueType Font > ii libvorbis0a 1.0.0-3 The Vorbis General Audio Compressi > ii libvorbisfile3 1.0.0-3 The Vorbis General Audio Compressi > ii xlibs 4.2.1-6 X Window System client libraries > ii zlib1g 1:1.1.4-11 compression library - runtime > > -- no debconf information > > > > > ______________________________________________________________________ > > Regards, Andy -- -- Kristian G. Kvilekval email:kris <at> cs.ucsb.edu office:(805)893-4276 http://www.cs.ucsb.edu/~kris ------------------------------------------------------- Enterprise Linux Forum Conference & Expo, June 4-6, 2003, Santa Clara The only event dedicated to issues related to Linux enterprise solutions www.enterpriselinuxforum.com
RSS Feed