Re: compareVersions bug?

Thanks, Curtis.

When I saw the changes that had been made in the CVS tree I had a
premonition that someone would fix the problem right before I submitted a
patch, heh - but at least I was able to brush up on my bash scripting
skills a bit. :)

And if you are able to clean it up any, please do - I don't know if it
has more to do with my unfamiliarity with shell scripting, but what took
me 5 minutes to fix up in the C version I adapted to Luau took me over
half an hour to work out straight in my head for the compareVersions
code.  I think it's just all those brackets and extraneous quotes that
get the better of me...

Also, since in the current CVS repo it appears this hasn't been changed,
I just wanted to point out a minor change in the patch I submitted: on
line 814, you have

	char1=`expr substr $a $counter 1`

I changed this to

	char1=`expr substr "$a" $counter 1`

(quotes around $a), since for one of the tests I would get a "expr:
syntax error" because $a == "" (same goes for line 823, where there's the
exact same statement except with char2 and $b).  I seem to still get that
error with the CVS version, so I thought I'd point it out.

Cheers,
David

On Wed, 31 Dec 2003 19:54:47 -0800, "Curtis L. Knight"
<knighcl@...> said:
> I had just commited some code changes when I saw your patch. Thanks for 
> the patch. Looking over it quickly, we seem to have basically done the 
> same thing. I will look over your submission and check it against CVS 
> and see if I can make it shorter or easier to understand for the next 
> person.