Re: [PATCH 3/3]: arm: Kirkwood: See to it that sent data is 8-byte aligned

> -----Original Message-----
> From: u-boot-bounces <at> lists.denx.de 
> [mailto:u-boot-bounces <at> lists.denx.de] On Behalf Of Wolfgang Denk
> Sent: Thursday, August 06, 2009 2:38 AM
> To: Ben Warren
> Cc: U-Boot ML
> Subject: Re: [U-Boot] [PATCH 3/3]: arm: Kirkwood: See to it 
> that sent data is 8-byte aligned
> 
> Dear Simon Kagstrom,
> 
> In message <20090702150401.06ded440 <at> marrow.netinsight.se> 
> Simon Kagstrom wrote:
> > See to it that sent data is 8-byte aligned
> > 
> > U-boot might use non-8-byte-aligned addresses for sending 
> data, which 
> > the kwgbe_send doesn't accept (bootp does this for me). This patch 
> > copies the data to be sent to a temporary buffer if it is 
> non-aligned.
Ack,
This is useful patch for kirkwood egiga driver, 
I have tested it -possible pls get this in.

On the other hand-
I had a suggestion to do this in upper layer (i.e. in net/eth.c) so that every client driver can benefit from
this. But we can do this latter too.

Regards..
Prafulla . .

> > 
> > Signed-off-by: Simon Kagstrom <simon.kagstrom <at> netinsight.net>
> > ---
> >  drivers/net/kirkwood_egiga.c |   26 ++++++++++++++++++++------
> >  1 files changed, 20 insertions(+), 6 deletions(-)
> 
> Ping?
> 
> Best regards,
> 
> Wolfgang Denk
> 
> -- 
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd <at> denx.de
> Q:  Why do mountain climbers rope themselves together?
> A:  To prevent the sensible ones from going home.
> _______________________________________________
> U-Boot mailing list
> U-Boot <at> lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>