Nathan Crawford | 6 Mar 18:08
Picon
Favicon

Re: PATCH dm9ks interrupt handling


--- chrispe <chris <at> edesix.com> wrote:

> 
> I was having problems with the OSD not receiving packets on a
> busy
> network. Typically I would notice this when a telnet session
> hung for
> 5-15 seconds when I pressed a key, but it also happened in
> many other
> circumstances.
> 
> I discovered that the driver had some code that disabled the
> receive
> interrupt after 10 packets were received. The interrupt would
> be re-
> enabled by completing a transmit or by a 5 second timer. This
> somewhat
> crazy code was presumably designed to reduce the load on the
> processor
> (or maybe the IRQ system) when the device is not actively
> communicating. However, on a network with a moderate amount of
> broadcast traffic it was very common for the device to stop
> receiving
> for several seconds and then overrun its receive buffer when
> the
> interrupt was re-enabled.
> 
> I have removed this mechanism and also removed the bogus ioctl
> handler
> that just returned success to all calls, which makes things
> like the
> mii interface look like they work, but always return junk!
> 
> Patch below.
> 
> Chris.

Are you sure this is a good idea?  Have you thoroughly tested
this?

Best Regards,

Nathan Crawford

 
____________________________________________________________________________________
Finding fabulous fares is fun.  
Let Yahoo! FareChase search your favorite travel sites to find flight and hotel bargains.
http://farechase.yahoo.com/promo-generic-14795097


Gmane