Re: 2.3.15 patches - QA includes to fix compile warnings

Daniel Black <dragonheart <at> gentoo.org> writes:

> 2.3.11+gcc-4.3 patch thanks to 01 Jun 2008; Diego Pettenò 
> <flameeyes <at> gentoo.org>
> https://bugs.gentoo.org/show_bug.cgi?id=224453
>
> Index: gnutls-2.3.11/doc/examples/ex-cxx.cpp
> ===================================================================
> --- gnutls-2.3.11.orig/doc/examples/ex-cxx.cpp
> +++ gnutls-2.3.11/doc/examples/ex-cxx.cpp
> @@ -4,6 +4,7 @@
>  #endif
>  #include <iostream>
>  #include <stdexcept>
> +#include <cstring>
>  #include <gnutls/gnutls.h>
>  #include <gnutls/gnutlsxx.h>

We solved this earlier by adding the following instead:

#include <string.h> /* for strlen */

That should be in 2.4.x too.  Is it better to use <cstring>?  I don't
know.

> gnutls-2.3.15-qa_gnutls_session_is_psk.patch is mine and fixes 
> gnutls_kx.c:392: warning: implicit declaration of 
> function '_gnutls_session_is_psk'
>
> --- ./lib/gnutls_state.h.orig	2008-06-19 18:54:50.000000000 +1000
> +++ ./lib/gnutls_state.h	2008-06-19 18:55:57.000000000 +1000
> @@ -58,6 +58,7 @@
>  
>  int _gnutls_session_is_resumable (gnutls_session_t session);
>  int _gnutls_session_is_export (gnutls_session_t session);
> +int _gnutls_session_is_psk (gnutls_session_t session);
>  
>  int _gnutls_openpgp_send_fingerprint (gnutls_session_t session);

This has been fixed already, but didn't make it for 2.4.0.

Thanks,
/Simon