Re: 2.3.15 patches - QA includes to fix compile warnings

Daniel Black <dragonheart <at> gentoo.org> writes:

> On Thu, 19 Jun 2008 08:39:40 pm Simon Josefsson wrote:
>> Daniel Black <dragonheart <at> gentoo.org> writes:
>> > 2.3.11+gcc-4.3 patch thanks to 01 Jun 2008; Diego Pettenò
>> > <flameeyes <at> gentoo.org>
>> > https://bugs.gentoo.org/show_bug.cgi?id=224453
>> >
>> > Index: gnutls-2.3.11/doc/examples/ex-cxx.cpp
>> > ===================================================================
>> > --- gnutls-2.3.11.orig/doc/examples/ex-cxx.cpp
>> > +++ gnutls-2.3.11/doc/examples/ex-cxx.cpp
>> > @@ -4,6 +4,7 @@
>> >  #endif
>> >  #include <iostream>
>> >  #include <stdexcept>
>> > +#include <cstring>
>> >  #include <gnutls/gnutls.h>
>> >  #include <gnutls/gnutlsxx.h>
>>
>> We solved this earlier by adding the following instead:
>>
>> #include <string.h> /* for strlen */
>>
>> That should be in 2.4.x too.  Is it better to use <cstring>?
>
> cstring is more c++ like. probably handles unicode and stuff better. not sure 
> if thats in this example.
>
>> I don't know.
>
> i trust Diego on this because i'm not sure either.

I searched a bit, and cstring seems better than string.h, so I made the
change in the 2.5.x branch.  I won't backport to 2.4.x unless there are
reports that using string.h causes compilation failure on some platform.

Thanks,
/Simon