8 Jul 2010 15:51
Re: support biarch gcore?
H.J. Lu <hjl.tools <at> gmail.com>
2010-07-08 13:51:55 GMT
2010-07-08 13:51:55 GMT
On Thu, Jul 8, 2010 at 4:15 AM, Ulrich Weigand <uweigand <at> de.ibm.com> wrote:
> H.J. Lu wrote:
>
>> It works. Here is a patch to add a testcase. OK to install?
>
> Maybe I'm missing something, but it looks like this is an identical
> copy of the gcore.exp test, except that the executable is built
> with -m32, right?
>
> What does this test check that wouldn't already be checked by running
> make check RUNTESTFLAGS="--target_board='unix/-m32' gcore.exp"
> ?
>
> Since you should be running the full -m32 testsuite anyway if you care
> about the bi-arch debugger, I don't think we want to duplicate this
> test case for no real gain ...
>
Very good point. There are some arch specific tests which are either
32bit or 64bit. Currently, we check target. It doesn't work -m32. We
need something like
/* { dg-require-effective-target lp64 } */
/* { dg-require-effective-target ilp32 } */
--
--
H.J.
RSS Feed