Re: Fwd: [PATCH] AutoSize fixes for bug 355408 - Please Review

On Wed, Jul 2, 2008 at 4:48 PM, Jonathan Pobst <monkey <at> jpobst.com> wrote:
> Hey Ivan,
>
> Your patch leaves two blocks of unreachable code.
>

Ops. I blame my editor's automagic unsurround feature :)

> Also, layout is extremely tricky and easily testable, so EVERY change to
> default/table/flow layout MUST have a test case.  See TableLayoutTest.cs.
>

Yeah I was going to write the tests, but thought I might get this
looked at first. So yeah, I will write the tests and then commit.
Thanks.
_______________________________________________
Mono-winforms-list maillist  -  Mono-winforms-list <at> lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list