Re: Proposed patch to modify #'style of line objects

Thanks, I've committed it to GDP.

(it won't look good for the next couple of days in the GDP output, since 
  we don't have the actual code patch merged with GDP yet, but it will 
be fixed after .35)

Cheers,
- Graham

Mats Bengtsson wrote:
> I have now added a convert-ly rule which issues a warning. Also, the 
> manual should
> be updated, by the following patch. Should I apply it to GIT or should 
> it rather
> be done in the GDP copy?
> 
> diff --git a/Documentation/user/text.itely b/Documentation/user/text.itely
> index 6e8cfc8..b835844 100644
> --- a/Documentation/user/text.itely
> +++ b/Documentation/user/text.itely
>  <at>  <at>  -195,7 +195,7  <at>  <at>  c2\startTextSpan b c\stopTextSpan a
> To print a solid line, use
> 
>  <at> example
> -\override TextSpanner #'dash-fraction = #'()
> +\override TextSpanner #'style = #'line
>  <at> end example
> 
> 
>  <at>  <at>  -757,7 +757,7  <at>  <at>  to tune them.
> 
>  <at> lilypond[relative=2,ragged-right,verbatim,fragment]
> d2 \glissando d'2
> -\once \override Glissando #'dash-fraction = #0.5
> +\override Glissando #'style = #'dashed-line
> d,2 \glissando d'2
> \override Glissando #'style = #'dotted-line
> d,2 \glissando d'2
> 
> 
>     /Mats
> 
> Graham Percival wrote:
>> Would it be easy to create a convert-ly rule for this?  (I can't 
>> remember what the old syntax was)
>>
>> Cheers,
>> - Graham
>>
>> Mats Bengtsson wrote:
>>> Since I haven't heard any objections, I have now commited the patch
>>> to GIT, so that style = #'line always means solid line.
>>>
>>>   /Mats
>>>
>>> Graham Percival wrote:
>>>> Mats Bengtsson wrote:
>>>>> I realize that this might break some existing code and have tried 
>>>>> to fix it
>>>>> in the regression test files I could find (the example 
>>>>> line-arrows.ly in LSR
>>>>> has to be updated correspondingly).
>>>>
>>>> LSR is still on 2.10.12, so this can't be fixed until it upgrades.  
>>>> (and that won't be until a 2.12 beta version, at the earliest)
>>>>
>>>>> Also, the current behavior is mentioned
>>>>> at one place in the manual, which should be updated in GDP.
>>>>
>>>> Easily done, once 2.11.35 (or .36) is out.
>>>>
>>>> Cheers,
>>>> - Graham
>>>
>>
>>
>> _______________________________________________
>> lilypond-devel mailing list
>> lilypond-devel <at> gnu.org
>> http://lists.gnu.org/mailman/listinfo/lilypond-devel
>