15 Jun 2012 07:42
Re: Issue 2602: \unfoldRepeats and \repeat tremolo 7,14,15 produces weird output (issue 6300092)
<dak <at> gnu.org>
2012-06-15 05:42:31 GMT
2012-06-15 05:42:31 GMT
Reviewers: colinpkcampbell_gmail.com, http://codereview.appspot.com/6300092/diff/6001/input/regression/display-lily-tests.ly File input/regression/display-lily-tests.ly (right): http://codereview.appspot.com/6300092/diff/6001/input/regression/display-lily-tests.ly#newcode193 input/regression/display-lily-tests.ly:193: \test ##[ \repeat tremolo 7 { c''32 b' } #] On 2012/06/15 03:02:52, Colin Campbell wrote: > Should these two lines both be c''32 or c''16? No. #[ #] is somewhat buggy and you can't, as a consequence, have one test use a non-4 default duration when the next test starts with a 4. Fixing this (in order to make the tests independent) would mean that every test starts with a default 4. This would affect a number of other tests. I decided not to bother. Try getting the tests to agree when both just use 32. It is not specific to those tests: you can't do this for any other sequence of tests as well. Description: Issue 2602: \unfoldRepeats and \repeat tremolo 7,14,15 produces weird output This just shamelessly copies the logic of make-repeat into unfold-repeats, on the assumption that we want to have the same rules apply for creating and unfolding tremoli. Please review this at http://codereview.appspot.com/6300092/ Affected files: M input/regression/display-lily-tests.ly M scm/define-music-display-methods.scm M scm/music-functions.scm
RSS Feed