problem in trunk

I did an svn update and full build this morning, and the reference is  
not
working properly. In the nav pane, the only thing that shows up is this:

Clicking Show application only results in an empty nav pane.

trunk nightly is currenly broken (404 error), so I don't know if the  
problem
exists there as well.

Lou

bug with extra focus event on mouseup in swf9 ?

Re: For Review: Change 20080905-Philip-4., Summary: Modify components to use setAttribute instead of setX

For Review: 20080906-laszlo-4 Summary: LzPix: Text misplacement on enlarged images, SWF8/9 and DHTML: LZPIX: Counter goes back 2 grids when scrolling backwards with less than 18 pictures on the grid

Change 20080906-laszlo-4 by laszlo <at> T43-L3XEXMW on 2008-09-06 05:05:53 EDT
    in /home/laszlo/src/svn/openlaszlo/trunk-ocelot
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: LzPix: Text misplacement on enlarged images, SWF8/9 and DHTML: 
LZPIX: Counter goes back 2 grids when scrolling backwards with less than 
18 pictures on the grid

New Features:

Bugs Fixed: LPP-6940 - LzPix: Text misplacement on enlarged images
            LPP-6871 - SWF8/9 and DHTML: LZPIX: Counter goes back 2 
grids when scrolling backwards with less than 18 pictures on the grid

Technical Reviewer: promanik
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

Tests: For 6940, expand the images and move forward one page.
    In an unmodified version, the text labels for the images
    would be centered over the images on the second page.  They
    should now be below the images, where expected.

    For 6871, expand the images so that there are only six on
    the page (or anything less than the maximum 18, really),
    move forward two or three pages, and then move back a page.
    In the unmodified version, it will go all the way back to
    the first page (e.g. images 1-6).  In the fixed version,
    it will go back to the previous page, as expected.

Files:
M      demos/lzpix/classes/photo.lzx
M      demos/lzpix/views/tools.lzx

Changeset: 
http://svn.openlaszlo.org/openlaszlo/patches/20080906-laszlo-4.tar

For Review: Change 20080905-maxcarlson-a Summary: UPDATED AGAIN: Move property cache lookups to LzNode, add persistent CSS cache

Change 20080905-maxcarlson-a by maxcarlson <at> Bank on 2008-09-05 13:34:45  
PDT
     in /Users/maxcarlson/openlaszlo/pagan-deities
     for http://svn.openlaszlo.org/openlaszlo/branches/pagan-deities

Summary: UPDATED AGAIN: Move property cache lookups to LzNode, add  
persistent CSS cache

Bugs Fixed: LPP-6938 - Improve CSS performance (partial)

Technical Reviewer: ptw
QA Reviewer: promanik

Details: Adding a persistent cache is crazy, but I tried it anyway.   
It turns out to reduce the number of calls to getPropertyValueFor() by  
289, and the total time spent by .19 seconds, with no regressions!

LzSprite.as - Add csscache capability, set to true

LzSprite.js,LzSprite.lzs - Add csscache capability, set to false

LzCSSStyle.js - Remove property value caching.

LzNode.lzs - Inline property value caching.  If csscache capability is  
true, restore the value from the persistent cache.

LaszloCanvas.lzs - Document and store canvas.builddate property from  
CanvasCompiler.java.  If csscache capability is true, restore the  
__LZcsscache property.

CanvasCompiler.java - Set canvas.builddate to the time when the  
application is built.

Tests: http://localhost:8080/pagan-deities/test/style/metasuite.lzx  
runs as before.  Note the first time is slower because it builds the  
cache.  Subsequent loads (without recompilation) should be faster by a  
lot.  Validate the profiler results by rebuilding the LFC, profiling
http://localhost:8080/pagan-deities/test/style/metasuite.lzx?lzr=swf7&profile=true&lzt=html 
.  Save the profiler results, then refresh the app and run again and  
you should see the hotspot go away:

Before:
         %  cumulative     self    calls     self    total   
name                                                          index
      time     seconds  seconds           ms/call  ms/call

       8.2%       0.29     0.29      347     0.84     1.00   
LzCSSStyle.getPropertyValueFor                                [19]
       7.2%       0.55     0.26        1   256.42   261.50   
LzSprite.prototype.__initCSSCache                             [27]
       3.7%       0.68     0.13      337     0.39     5.19  <node>/ 
<node>                                                 [6]
       3.7%       0.81     0.13      338     0.39     1.35  <node>/ 
__LZapplyArgs                                          [16]
       2.8%       0.91     0.10      233     0.43     0.43   
LzTextSprite.prototype.getTextfieldHeight                     [58]
       2.2%       0.99     0.08     1000     0.08     0.20  LzDelegate/ 
register                                           [36]

After:
         %  cumulative     self    calls     self    total   
name                                                          index
      time     seconds  seconds           ms/call  ms/call

       4.3%       0.13     0.13      338     0.37     1.27  <node>/ 
__LZapplyArgs                                          [17]
       4.2%       0.25     0.12      337     0.36     4.23  <node>/ 
<node>                                                 [6]
       3.9%       0.36     0.11       58     1.98     2.34   
LzCSSStyle.getPropertyValueFor                                [41]
       3.6%       0.47     0.11      318     0.33     1.45  <node>/ 
applyConstraint                                        [15]
       3.1%       0.56     0.09      233     0.38     0.38   
LzTextSprite.prototype.getTextfieldHeight                     [51]

Once again, I'm curious to see if you see results from running webtop.

Files:
M      WEB-INF/lps/lfc/kernel/swf/LzSprite.as
M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.lzs
M      WEB-INF/lps/lfc/services/LzCSSStyle.js
M      WEB-INF/lps/lfc/core/LzNode.lzs
M      WEB-INF/lps/lfc/views/LaszloCanvas.lzs
M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
CanvasCompiler.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080905-maxcarlson-a.tar

For Review: Change 20080905-laszlo-2 Summary: States example 5 miscounts applies

Change 20080905-laszlo-2 by laszlo <at> T43-L3XEXMW on 2008-09-05 21:23:33 EDT
in /home/laszlo/src/svn/openlaszlo/trunk-ocelot
for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: States example 5 miscounts applies

New Features:

Bugs Fixed: LPP-6939 - States example 5 miscounts applies

Technical Reviewer: promanik
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: Overlooked this with my last checkin to this
file. I forgot to make it only count applies when
applied was true and not just whenever applied
changed.

Tests: Run the modified file. It should now have the
correct count.

Files:
M docs/src/developers/programs/states-$5.lzx

Changeset: 
http://svn.openlaszlo.org/openlaszlo/patches/20080905-laszlo-2.tar

For Review: Change 20080905-maxcarlson-a Summary: UPDATED: Move property cache lookups to LzNode (working this time)

Change 20080905-maxcarlson-a by maxcarlson <at> Bank on 2008-09-05 13:34:45  
PDT
     in /Users/maxcarlson/openlaszlo/pagan-deities
     for http://svn.openlaszlo.org/openlaszlo/branches/pagan-deities

Summary: UPDATED: Move property cache lookups to LzNode (working this  
time)

Bugs Fixed: LPP-6938 - Improve CSS performance (partial)

Technical Reviewer: ptw
QA Reviewer: promanik

Details: LzCSSStyle.js - Remove property value caching.

LzNode.lzs - Inline property value caching.

Tests: http://localhost:8080/pagan-deities/test/style/metasuite.lzx  
runs as before.  Moving the cache lookup doesn't change the behavior  
at all, at least with this test.  I still see the same number of calls  
to getPropertyValueFor(), so each call is a cache miss.

This implies fiddling with the cache won't get us much.  I'm curious  
to see if you see any cache hits running webtop.

Files:
M      WEB-INF/lps/lfc/services/LzCSSStyle.js
M      WEB-INF/lps/lfc/core/LzNode.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080905-maxcarlson-a.tar

For Review: Change 20080905-Philip-4. Summary: Modify components to use setAttribute instead of setX

Change 20080905-Philip-4 by Philip <at> Philip-DC on 2008-09-05 16:39:02 EDT
     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Modify components to use setAttribute instead of setX

New Features:

Bugs Fixed: LPP-5644 (partial)

Technical Reviewer: ptw
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
I ran a script I wrote (/WEB-INF/lps/server/bin/convert_setters.pl) 
on the components. This modifies a call like,

   this.setText(t)  ==>   this.setAttribute('text', t);

The tool isn't perfect because some classes define a local methods 
(ie. setText()) that doesn't derive from a view. However, it is >90% correct.

There are still some setters in other non-view files I need to convert.

I only modified the calendar demo app. I will modify the other 
apps/tests as a separate changeset.

I am checking this code in. The most interesting file to look at is 
convert_setters.pl. It is based upon convert_required.pl.

Tests:
component examples work again. recursion errors trying to run 
calendar are gone. deprecated messages about using setX in the 
components are gone.

Files:
A      WEB-INF/lps/server/bin/convert_setters.pl
M      lps/components/queens-charts/shared/piepiece.lzx
M      lps/components/queens-charts/shared/wholepie.lzx
M      lps/components/queens-charts/shared/chartzoomer.lzx
M      lps/components/queens-charts/shared/legend.lzx
M      lps/components/queens-charts/shared/label.lzx
M      lps/components/rpc/soap.lzx
M      lps/components/debugger/debugger.lzx
M      lps/components/debugger/newcontent.lzx
M      lps/components/debugger/scrollingtext.lzx
M      lps/components/charts/columnchart/columnchartplotarea.lzx
M      lps/components/charts/piechart/piepiece.lzx
M      lps/components/charts/addon/slider/slider.lzx
M      lps/components/charts/addon/zoomarea.lzx
M      lps/components/charts/barchart/barchartplotarea.lzx
M      lps/components/charts/common/tickmarklabel.lzx
M      lps/components/charts/common/valuepoints.lzx
M      lps/components/charts/common/datamarker.lzx
M      lps/components/charts/common/horizontalaxis.lzx
M      lps/components/charts/common/label.lzx
M      lps/components/charts/common/valueregion.lzx
M      lps/components/charts/common/valueline.lzx
M      lps/components/charts/common/datatip.lzx
M      lps/components/charts/common/rectangularchart.lzx
M      lps/components/charts/common/legend.lzx
M      lps/components/charts/common/databar.lzx
M      lps/components/charts/common/verticalaxis.lzx
M      lps/components/charts/linechart/linechartplotarea.lzx
M      lps/components/lz/gridcolumn.lzx
M      lps/components/lz/button.lzx
M      lps/components/lz/tabelement.lzx
M      lps/components/lz/listitem.lzx
M      lps/components/lz/basefloatinglist.lzx
M      lps/components/lz/hscrollbar.lzx
M      lps/components/lz/simpletext.lzx
M      lps/components/lz/floatinglist.lzx
M      lps/components/lz/menu.lzx
M      lps/components/lz/alert.lzx
M      lps/components/lz/combobox.lzx
M      lps/components/lz/vscrollbar.lzx
M      lps/components/lz/list.lzx
M      lps/components/lz/datepicker.lzx
M      lps/components/lz/slider.lzx
M      lps/components/lz/scrollbar.lzx
M      lps/components/lz/windowpanel.lzx
M      lps/components/lz/edittext.lzx
M      lps/components/lz/gridtext.lzx
M      lps/components/lz/datacombobox.lzx
M      lps/components/incubator/lzcombobox_class.lzx
M      lps/components/incubator/custombutton.lzx
M      lps/components/incubator/tooltip/tooltipview.lzx
M      lps/components/incubator/tooltip/tooltip.lzx
M      lps/components/incubator/newvscrollbar.lzx
M      lps/components/incubator/lwzCalendar/lwzEncalendar.lzx
M      lps/components/incubator/roundrectbutton.lzx
M      lps/components/incubator/baseslider.lzx
M      lps/components/incubator/ulink.lzx
M      lps/components/incubator/baseedittext.lzx
M      lps/components/incubator/stylishbutton.lzx
M      lps/components/incubator/validators/basevalidator.lzx
M      lps/components/incubator/defaultlistitem.lzx
M      lps/components/incubator/uploader/fileuploadlist.lzx
M      lps/components/incubator/newhscrollbar.lzx
M      lps/components/incubator/colorslider.lzx
M      lps/components/incubator/autocompletecombobox.lzx
M      lps/components/incubator/test/libflickr-test.lzx
M      lps/components/incubator/draglib.lzx
M      lps/components/incubator/opttree/opttree.lzx
M      lps/components/incubator/vslider.lzx
M      lps/components/incubator/stepper.lzx
M      lps/components/incubator/lzeditcombobox.lzx
M      lps/components/incubator/rich-text/linkdialog.lzx
M      lps/components/incubator/rich-text/formatfontcolor.lzx
M      lps/components/incubator/borderinput.lzx
M      lps/components/extensions/html.lzx
M      lps/components/extensions/drawview.lzx
M      lps/components/extensions/av/videoview.lzx
M      lps/components/extensions/views/richinputtext.lzx
M      lps/components/utils/performance/library.lzx
M      lps/components/utils/diagnostic/inittimer.lzx
M      lps/components/utils/diagnostic/inspector/colormenu.lzx
M      lps/components/utils/diagnostic/inspector/inspector.lzx
M      lps/components/utils/diagnostic/frametimer.lzx
M      lps/components/utils/replicator/replicator.lzx
M      lps/components/utils/traits/cssable.lzx
M      lps/components/base/basebutton.lzx
M      lps/components/base/basegridrow.lzx
M      lps/components/base/basescrollbar.lzx
M      lps/components/base/basewindow.lzx
M      lps/components/base/basecombobox.lzx
M      lps/components/base/basetabslider.lzx
M      lps/components/base/basefocusview.lzx
M      lps/components/base/basedatepicker.lzx
M      lps/components/base/basetrackgroup.lzx
M      lps/components/base/baseslider.lzx
M      lps/components/base/basegrid.lzx
M      lps/components/base/basedatacombobox.lzx
M      lps/components/base/basegridcolumn.lzx
M      lps/components/base/style.lzx
M      demos/calendar/simpletimelayout.lzx
M      demos/calendar/cal-button.lzx
M      demos/calendar/calendar.lzx
M      demos/calendar/vscrollbar.lzx
M      demos/calendar/infopanel.lzx
M      demos/calendar/day.lzx
M      demos/calendar/event.lzx
M      demos/calendar/eventselector.lzx
M      demos/calendar/gridsliderlayout.lzx
M      demos/calendar/selected-daylook.lzx
M      demos/calendar/basepanel.lzx
M      demos/calendar/textbox.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080905-Philip-4.tar

For Review: Change 20080905-maxcarlson-a Summary: Move property cache lookups to LzNode

Change 20080905-maxcarlson-a by maxcarlson <at> Bank on 2008-09-05 13:34:45  
PDT
     in /Users/maxcarlson/openlaszlo/pagan-deities
     for http://svn.openlaszlo.org/openlaszlo/branches/pagan-deities

Summary: Move property cache lookups to LzNode

Bugs Fixed: LPP-6938 - Improve CSS performance

Technical Reviewer: ptw
QA Reviewer: promanik

Details: LzCSSStyle.js - Remove property value caching.

LzNode.lzs - Inline property value caching.

Tests: http://localhost:8080/pagan-deities/test/style/metasuite.lzx  
runs as before

Files:
M      WEB-INF/lps/lfc/services/LzCSSStyle.js
M      WEB-INF/lps/lfc/core/LzNode.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080905-maxcarlson-a.tar

For Review: Change 20080905-ptw-q Summary: Address review comments (part 1)

Change 20080905-ptw-q by ptw <at> dueling-banjos.home on 2008-09-05  
14:23:07 EDT
     in /Users/ptw/OpenLaszlo/krispy-kreme
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Address review comments (part 1)

Technical Reviewer: a.bargull <at> intensis.de (pending)

Details:
     LzMessage: indexOf is in superclass, add static xmlEscape,
     LzSourceMessage/message, and correct constructor signature.

     LzDebug: Revise eval protocol: echo in debugger, call console with
     expression to eval, console calls back to Debugger/displayResult.
     Move _dbg_log_all_writes to Debugger/log_all_writes.  Use var
     declaration every time you set Debug to silence compiler warnings.

     LzFlashRemote, LzDebug: Clean up addText, simplify defaulting of
     color/type, adjust doEval to new protocol.

     LzCompiler: remove unreachable if branch

     LzMessage: fix date type-ohs, move xmlEscape here

     LzBootstrapDebugService:  Document the console 'interface' (even
     though I cannot declare it as an interface right now).  Make sure
     the bootstrap console implements it.  Adjust the logger so it
     works for Safari's console, move xmlEscape from here

     debugger: Clean up global comment, addText

Tests:
     ant lztest, smokecheck

Files:
M      WEB-INF/lps/lfc/debugger/LzMessage.lzs
M      WEB-INF/lps/lfc/debugger/LzDebug.lzs
M      WEB-INF/lps/lfc/debugger/platform/swf/LzFlashRemote.as
M      WEB-INF/lps/lfc/debugger/platform/swf/LzDebug.as
M      WEB-INF/lps/lfc/debugger/platform/dhtml/LzDebug.js
M      WEB-INF/lps/lfc/debugger/LzCompiler.lzs
M      WEB-INF/lps/lfc/compiler/LzMessage.lzs
M      WEB-INF/lps/lfc/compiler/LzBootstrapDebugService.lzs
M      lps/components/debugger/debugger.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080905-ptw-q.tar

There are many setter-related issues in components

Hi Amy,

I'm working on a changeset to fix the setter-related issues that have 
cropped up (ex: LPP-6936). I don't think anyone should do serious 
testing until the next changeset is checked in.

Thanks!

Phil