For Review: Change 20080905-ptw-q Summary: Address review comments (part 1)

Change 20080905-ptw-q by ptw <at> dueling-banjos.home on 2008-09-05  
14:23:07 EDT
     in /Users/ptw/OpenLaszlo/krispy-kreme
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Address review comments (part 1)

Technical Reviewer: a.bargull <at> intensis.de (pending)

Details:
     LzMessage: indexOf is in superclass, add static xmlEscape,
     LzSourceMessage/message, and correct constructor signature.

     LzDebug: Revise eval protocol: echo in debugger, call console with
     expression to eval, console calls back to Debugger/displayResult.
     Move _dbg_log_all_writes to Debugger/log_all_writes.  Use var
     declaration every time you set Debug to silence compiler warnings.

     LzFlashRemote, LzDebug: Clean up addText, simplify defaulting of
     color/type, adjust doEval to new protocol.

     LzCompiler: remove unreachable if branch

     LzMessage: fix date type-ohs, move xmlEscape here

     LzBootstrapDebugService:  Document the console 'interface' (even
     though I cannot declare it as an interface right now).  Make sure
     the bootstrap console implements it.  Adjust the logger so it
     works for Safari's console, move xmlEscape from here

     debugger: Clean up global comment, addText

Tests:
     ant lztest, smokecheck

Files:
M      WEB-INF/lps/lfc/debugger/LzMessage.lzs
M      WEB-INF/lps/lfc/debugger/LzDebug.lzs
M      WEB-INF/lps/lfc/debugger/platform/swf/LzFlashRemote.as
M      WEB-INF/lps/lfc/debugger/platform/swf/LzDebug.as
M      WEB-INF/lps/lfc/debugger/platform/dhtml/LzDebug.js
M      WEB-INF/lps/lfc/debugger/LzCompiler.lzs
M      WEB-INF/lps/lfc/compiler/LzMessage.lzs
M      WEB-INF/lps/lfc/compiler/LzBootstrapDebugService.lzs
M      lps/components/debugger/debugger.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080905-ptw-q.tar