6 Sep 00:13
For Review: Change 20080905-maxcarlson-a Summary: UPDATED: Move property cache lookups to LzNode (working this time)
From: Max Carlson <max <at> openlaszlo.org>
Subject: For Review: Change 20080905-maxcarlson-a Summary: UPDATED: Move property cache lookups to LzNode (working this time)
Newsgroups: gmane.comp.java.openlaszlo.devel
Date: 2008-09-05 22:14:21 GMT
Subject: For Review: Change 20080905-maxcarlson-a Summary: UPDATED: Move property cache lookups to LzNode (working this time)
Newsgroups: gmane.comp.java.openlaszlo.devel
Date: 2008-09-05 22:14:21 GMT
Change 20080905-maxcarlson-a by maxcarlson <at> Bank on 2008-09-05 13:34:45
PDT
in /Users/maxcarlson/openlaszlo/pagan-deities
for http://svn.openlaszlo.org/openlaszlo/branches/pagan-deities
Summary: UPDATED: Move property cache lookups to LzNode (working this
time)
Bugs Fixed: LPP-6938 - Improve CSS performance (partial)
Technical Reviewer: ptw
QA Reviewer: promanik
Details: LzCSSStyle.js - Remove property value caching.
LzNode.lzs - Inline property value caching.
Tests: http://localhost:8080/pagan-deities/test/style/metasuite.lzx
runs as before. Moving the cache lookup doesn't change the behavior
at all, at least with this test. I still see the same number of calls
to getPropertyValueFor(), so each call is a cache miss.
This implies fiddling with the cache won't get us much. I'm curious
to see if you see any cache hits running webtop.
Files:
M WEB-INF/lps/lfc/services/LzCSSStyle.js
M WEB-INF/lps/lfc/core/LzNode.lzs
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080905-maxcarlson-a.tar
RSS Feed