9 Feb 21:23
[Laszlo-reviews] For Review: Change 20100209-ptw-6 Summary: Make tag compiler runtime neutral
P T Withington <ptw <at> pobox.com>
2010-02-09 20:23:01 GMT
2010-02-09 20:23:01 GMT
[Would like to get this into 4.7.1 because I think it is the only thing blocking swf9 .lzo's]
Change 20100209-ptw-6 by ptw <at> repo-man.home on 2010-02-09 15:06:31 EST
in /Users/ptw/OpenLaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Make tag compiler runtime neutral
Bugs Fixed: LPP-8604 runtime-specific code being inserted by ClassModel in the tag compiler
Technical Reviewer: hminsky (pending)
QA Reviewer: max (pending)
Details:
NodeModel: Don't put file/line on nodes classes. It's
non-portable, and we have a better mechanism (backtrace
annotations). There is no reason to disallow <passthrough> in the
tag compiler, let the back end worry about that.
ClassModel: Be honest and declare a valid default constructor for
all tag classes (instead of relying on undocumented behavior of
our class runtime).
build.xml: type-oh noticed in passing
Tests:
smokecheck and test case from forums works in all runtimes.
Files:
M WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
M WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java
M build.xml
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100209-ptw-6.tar
RSS Feed