Re: Review Request: Move core parts of KexiDB lib to libcalligradb

<div>
  <div>
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8"><tr>
<td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105464/">http://git.reviewboard.kde.org/r/105464/</a>
     </td>
    </tr></table>
<br><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8"><tr>
<td>

<div>Review request for Calligra, Adam Pigg, C. Boemann, Smit Patel, Dimitrios Tanis, and Oleg Kukharchuk.</div>
<div>By Jaros&#322;aw Staniek.</div>

<p>Updated July 7, 2012, 12:34 a.m.</p>

<h1>Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10"><tr>
<td>
   Move core parts of KexiDB lib from kexi/kexidb to calligra/libs/db (libcalligradb) for reuse by Word's Biblio module and possibly other places in Calligra.

Details at http://community.kde.org/Kexi/KexiDB#libCalligraDB

* GUI- or Kexi-related bits such as validators are still in Kexi
* Only the SQLite3 driver is moved to libcalligradb, others stay within Kexi
** thus, calligra libs depend on the driver, i.e. depend on SQLite3 (this was the case already for Words and Kexi)
** calligra libs depend on ICU as well for proper unicode handling (which is dependency of Qt 5 anyway)
* Predicate library, as a Qt-only component, will replace functionality of the calligradb lib
* sqlitedump tool used for database for interactive database compacting stays in Kexi; if needed could be moved to libs/ too
* a few functions from libkexiutils moved to libcalligradb, so libkexiutils is not dependency
* for simplicity/API stability, namespace stays as KexiDB
* README.PACKAGERS file updated
  </td>
 </tr></table>
<h1>Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10"><tr>
<td>
   Kexi and kexidbtest runs properly
  </td>
 </tr></table>
<h1>Diffs </h1>
<ul>
<li>CMakeLists.txt <span>(33cdabb)</span>
</li>

 <li>README.PACKAGERS <span>(277d0e7)</span>
</li>

 <li>cmake/modules/FindCalligraSqlite.cmake <span>(be39e5f)</span>
</li>

 <li>kexi/CMakeLists.txt <span>(a724a34)</span>
</li>

 <li>kexi/core/CMakeLists.txt <span>(2b2a0bb)</span>
</li>

 <li>kexi/core/KexiMainWindowIface.h <span>(797c2cb)</span>
</li>

 <li>kexi/core/KexiRecentProjects.cpp <span>(d3e9921)</span>
</li>

 <li>kexi/core/KexiView.cpp <span>(fd32219)</span>
</li>

 <li>kexi/core/KexiWindow.cpp <span>(5b3bc11)</span>
</li>

 <li>kexi/core/kexi.h <span>(b6eb4a3)</span>
</li>

 <li>kexi/core/kexi.cpp <span>(4408e8b)</span>
</li>

 <li>kexi/core/kexiblobbuffer.cpp <span>(37ede52)</span>
</li>

 <li>kexi/core/kexidbconnectionset.h <span>(e47eaa3)</span>
</li>

 <li>kexi/core/kexidbshortcutfile.cpp <span>(95c499b)</span>
</li>

 <li>kexi/core/kexiguimsghandler.h <span>(91c6a2c)</span>
</li>

 <li>kexi/core/kexiguimsghandler.cpp <span>(c1c2b80)</span>
</li>

 <li>kexi/core/kexiinternalpart.cpp <span>(13a834a)</span>
</li>

 <li>kexi/core/kexipart.h <span>(ad12383)</span>
</li>

 <li>kexi/core/kexipart.cpp <span>(7ffe8896)</span>
</li>

 <li>kexi/core/kexipartinfo.cpp <span>(a89cd38)</span>
</li>

 <li>kexi/core/kexipartmanager.h <span>(474fb31c)</span>
</li>

 <li>kexi/core/kexipartmanager.cpp <span>(050b051)</span>
</li>

 <li>kexi/core/kexiproject.h <span>(e9e366b)</span>
</li>

 <li>kexi/core/kexiproject.cpp <span>(1ce37ad)</span>
</li>

 <li>kexi/core/kexiprojectconnectiondata.h <span>(a165bfe)</span>
</li>

 <li>kexi/core/kexiprojectconnectiondata.cpp <span>(67cba7d)</span>
</li>

 <li>kexi/core/kexiprojectdata.h <span>(49fbe74)</span>
</li>

 <li>kexi/core/kexiprojectdata.cpp <span>(774e2e2)</span>
</li>

 <li>kexi/core/kexiprojectset.h <span>(0c281dc)</span>
</li>

 <li>kexi/core/kexiprojectset.cpp <span>(2ae1c2b)</span>
</li>

 <li>kexi/core/kexisearchandreplaceiface.h <span>(ca99062)</span>
</li>

 <li>kexi/core/kexistartupdata.cpp <span>(74a81e4)</span>
</li>

 <li>kexi/core/kexitabledesignerinterface.h <span>(5859ee6)</span>
</li>

 <li>kexi/core/kexitemplateloader.cpp <span>(901994c)</span>
</li>

 <li>kexi/core/kexitextmsghandler.cpp <span>(31f1d0b)</span>
</li>

 <li>kexi/formeditor/CMakeLists.txt <span>(bd5ca24)</span>
</li>

 <li>kexi/formeditor/WidgetInfo.h <span>(8b66912)</span>
</li>

 <li>kexi/formeditor/form.cpp <span>(5746780)</span>
</li>

 <li>kexi/formeditor/kexiformeventhandler.cpp <span>(195a63f)</span>
</li>

 <li>kexi/kexidb/CMakeLists.txt <span>(37ea839)</span>
</li>

 <li>kexi/kexidb/RecordData.h <span>(074d3ba)</span>
</li>

 <li>kexi/kexidb/RecordData.cpp <span>(03a6ddb)</span>
</li>

 <li>kexi/kexidb/admin.h <span>(af28574)</span>
</li>

 <li>kexi/kexidb/admin.cpp <span>(2e9e981)</span>
</li>

 <li>kexi/kexidb/alter.h <span>(1d3d26e)</span>
</li>

 <li>kexi/kexidb/alter.cpp <span>(784b93b)</span>
</li>

 <li>kexi/kexidb/common.pro <span>(18235e2)</span>
</li>

 <li>kexi/kexidb/connection.h <span>(e77d840)</span>
</li>

 <li>kexi/kexidb/connection.cpp <span>(a81f4c1)</span>
</li>

 <li>kexi/kexidb/connection_p.h <span>(b882267)</span>
</li>

 <li>kexi/kexidb/connectiondata.h <span>(be7f472)</span>
</li>

 <li>kexi/kexidb/connectiondata.cpp <span>(4c75f5c)</span>
</li>

 <li>kexi/kexidb/cursor.h <span>(0dfdb17)</span>
</li>

 <li>kexi/kexidb/cursor.cpp <span>(d7450a3)</span>
</li>

 <li>kexi/kexidb/cursor_p.h <span>(16083e7)</span>
</li>

 <li>kexi/kexidb/dbobjectnamevalidator.h <span>(fd3d763)</span>
</li>

 <li>kexi/kexidb/dbobjectnamevalidator.cpp <span>(1d79c87)</span>
</li>

 <li>kexi/kexidb/dbproperties.h <span>(69f718b)</span>
</li>

 <li>kexi/kexidb/dbproperties.cpp <span>(2ee7fa4)</span>
</li>

 <li>kexi/kexidb/driver.h <span>(d51a870)</span>
</li>

 <li>kexi/kexidb/driver.cpp <span>(8ece2aa)</span>
</li>

 <li>kexi/kexidb/driver_p.h <span>(67f312c)</span>
</li>

 <li>kexi/kexidb/driver_p.cpp <span>(af400c6)</span>
</li>

 <li>kexi/kexidb/drivermanager.h <span>(140be5c)</span>
</li>

 <li>kexi/kexidb/drivermanager.cpp <span>(08729ab)</span>
</li>

 <li>kexi/kexidb/drivermanager_p.h <span>(28eff57)</span>
</li>

 <li>kexi/kexidb/drivers/CMakeLists.txt <span>(9e48942)</span>
</li>

 <li>kexi/kexidb/drivers/mySQL/CMakeLists.txt <span>(747c337)</span>
</li>

 <li>kexi/kexidb/drivers/mySQL/mysqlconnection.h <span>(cd69b53)</span>
</li>

 <li>kexi/kexidb/drivers/mySQL/mysqlconnection.cpp <span>(dac326d)</span>
</li>

 <li>kexi/kexidb/drivers/mySQL/mysqlconnection_p.h <span>(b29e721)</span>
</li>

 <li>kexi/kexidb/drivers/mySQL/mysqlconnection_p.cpp <span>(98f7985)</span>
</li>

 <li>kexi/kexidb/drivers/mySQL/mysqlcursor.h <span>(b3a8dcd)</span>
</li>

 <li>kexi/kexidb/drivers/mySQL/mysqlcursor.cpp <span>(5e302db)</span>
</li>

 <li>kexi/kexidb/drivers/mySQL/mysqldriver.h <span>(afab017)</span>
</li>

 <li>kexi/kexidb/drivers/mySQL/mysqldriver.cpp <span>(90408b9)</span>
</li>

 <li>kexi/kexidb/drivers/mySQL/mysqlpreparedstatement.h <span>(d2cba87)</span>
</li>

 <li>kexi/kexidb/drivers/odbc/kodbcdriver.h <span>(03e0fb1)</span>
</li>

 <li>kexi/kexidb/drivers/odbc/kodbcdriver.cpp <span>(f375e47)</span>
</li>

 <li>kexi/kexidb/drivers/odbc/odbcconnection.h <span>(cd97d2c)</span>
</li>

 <li>kexi/kexidb/drivers/odbc/odbcconnection.cpp <span>(300fde9)</span>
</li>

 <li>kexi/kexidb/drivers/odbc/odbcconnection_p.h <span>(6124d9b)</span>
</li>

 <li>kexi/kexidb/drivers/odbc/odbcconnection_p.cpp <span>(2ffbaa5)</span>
</li>

 <li>kexi/kexidb/drivers/odbc/odbccursor.h <span>(afdaedd)</span>
</li>

 <li>kexi/kexidb/drivers/odbc/odbccursor.cpp <span>(8fd2c7b)</span>
</li>

 <li>kexi/kexidb/drivers/odbc/odbcdriver.h <span>(a9a1b8b)</span>
</li>

 <li>kexi/kexidb/drivers/odbc/odbcdriver.cpp <span>(c7653af)</span>
</li>

 <li>kexi/kexidb/drivers/odbc/odbcpreparedstatement.h <span>(1cb02dd)</span>
</li>

 <li>kexi/kexidb/drivers/oracle/oracleconnection.h <span>(1dc9589)</span>
</li>

 <li>kexi/kexidb/drivers/oracle/oracleconnection_p.h <span>(3c31c8c)</span>
</li>

 <li>kexi/kexidb/drivers/oracle/oracleconnection_p.cpp <span>(22ff9fc)</span>
</li>

 <li>kexi/kexidb/drivers/oracle/oraclecursor.h <span>(332b464)</span>
</li>

 <li>kexi/kexidb/drivers/oracle/oraclecursor.cpp <span>(ebfce51)</span>
</li>

 <li>kexi/kexidb/drivers/oracle/oracledriver.h <span>(0589f37)</span>
</li>

 <li>kexi/kexidb/drivers/oracle/oracledriver.cpp <span>(0f7cb29)</span>
</li>

 <li>kexi/kexidb/drivers/oracle/oraclepreparedstatement.h <span>(e09ffa6)</span>
</li>

 <li>kexi/kexidb/drivers/pqxx/CMakeLists.txt <span>(06ed2ff)</span>
</li>

 <li>kexi/kexidb/drivers/pqxx/pqxxconnection.h <span>(2f6d6e9)</span>
</li>

 <li>kexi/kexidb/drivers/pqxx/pqxxconnection.cpp <span>(700b195)</span>
</li>

 <li>kexi/kexidb/drivers/pqxx/pqxxconnection_p.h <span>(9e66343)</span>
</li>

 <li>kexi/kexidb/drivers/pqxx/pqxxcursor.h <span>(8858b3f)</span>
</li>

 <li>kexi/kexidb/drivers/pqxx/pqxxcursor.cpp <span>(0086305)</span>
</li>

 <li>kexi/kexidb/drivers/pqxx/pqxxdriver.h <span>(c50b065)</span>
</li>

 <li>kexi/kexidb/drivers/pqxx/pqxxdriver.cpp <span>(3a47cf8)</span>
</li>

 <li>kexi/kexidb/drivers/pqxx/pqxxpreparedstatement.h <span>(ba0f860)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/CMakeLists.txt <span>(6933562)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/dump/CMakeLists.txt <span>(bf982f8)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/dump/README <span>(ba4c33f)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/dump/main.cpp <span>(98abfeb)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/dump/shell.c <span>(d10d436)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/icu/CMakeLists.txt <span>(fa81579)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/icu/README.txt <span>(01291e6)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/icu/icu.c <span>(60799c4)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/icu/sqliteicu.h <span>(4c9a4f9)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/kexidb_sqlite3driver.desktop <span>(4ff6cb7)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/sqliteadmin.h <span>(1a232c1)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/sqliteadmin.cpp <span>(8715d12)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/sqlitealter.cpp <span>(30c5ba0)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/sqliteconnection.h <span>(9d20806)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/sqliteconnection.cpp <span>(4877506)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/sqliteconnection_p.h <span>(ae701a2)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/sqlitecursor.h <span>(5860794)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/sqlitecursor.cpp <span>(cfc6102)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/sqlitedriver.h <span>(b745dfc)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/sqlitedriver.cpp <span>(7124ba9)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/sqlitekeywords.cpp <span>(735f446)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/sqlitepreparedstatement.h <span>(8411dfe)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/sqlitepreparedstatement.cpp <span>(ffb751e)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/sqlitevacuum.h <span>(d9a8cfd)</span>
</li>

 <li>kexi/kexidb/drivers/sqlite/sqlitevacuum.cpp <span>(5c20482)</span>
</li>

 <li>kexi/kexidb/drivers/sybase/CMakeLists.txt <span>(66c2c56)</span>
</li>

 <li>kexi/kexidb/drivers/sybase/sybaseconnection.h <span>(876ed88)</span>
</li>

 <li>kexi/kexidb/drivers/sybase/sybaseconnection.cpp <span>(2064afe)</span>
</li>

 <li>kexi/kexidb/drivers/sybase/sybaseconnection_p.h <span>(8b50690)</span>
</li>

 <li>kexi/kexidb/drivers/sybase/sybaseconnection_p.cpp <span>(aef7afb)</span>
</li>

 <li>kexi/kexidb/drivers/sybase/sybasecursor.h <span>(3f1b200)</span>
</li>

 <li>kexi/kexidb/drivers/sybase/sybasecursor.cpp <span>(29e3870)</span>
</li>

 <li>kexi/kexidb/drivers/sybase/sybasedriver.cpp <span>(6262f83)</span>
</li>

</ul>
<p><a href="http://git.reviewboard.kde.org/r/105464/diff/">View Diff</a></p>

  </td>
 </tr></table>
</div>
 </div>