Mark Gaiser | 1 Nov 2011 20:01

Review Request: Improved Button.qml in PlasmaComponents

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103020/

Review request for KDE Runtime, Plasma and Marco Martin.

By Mark Gaiser.

Description

I - quite heavily - modified the Button.qml to just look better. The list of changes: - Added myself to the copyright :p - Added a second leftMargin to the text if an icon was used. The icon and text where a little to close. - Added surfacePressed and renamed surface to surfaceNormal. This is done for a cross fade between 2 images. Works really nice! - Added a parallel animation for the cross fade. You just have to test this out! To do so, make a button and press/release it. You will see the fade effect but look carefully since it only lasts 100 milliseconds ;) - Removed some - now obsolete - javascript code - Fixed the Text{} to use the additional margin space when an icon is used For the added animation. This is a crossfade and it looks really nice when you press/release a button.

Testing

Made some buttons and played with them. It all seems to be working just fine.

Diffs

plasma/declarativeimports/plasmacomponents/qml/Button.qml (d7b62d7)

View Diff