Re: adding a method to KoCommandHistory

On Friday 03 March 2006 12:23, Clarence Dang wrote:
> Also, I couldn't subclass {K,Ko}CommandHistory to do what I wanted: amount of 
> undo/redo history also bounded by estimated memory required.

Interesting. Can you have a look at kcommandhistory in kdelibs trunk and suggest
a patch? The problem is that we can't just make clipCommands virtual, it needs to adjust 
a number of private member vars; we rather need clipCommands to call a virtual
method to find out how many commands to remove in both directions.

> 1. I didn't like the code esp. the way the history clipping code was written.

I agree. This is why I rewrote it all in trunk, please have a look.

> 2. It would require Makefile.am trickery to create a library to isolate the 
> LGPL {K,Ko}CommandHistory from the BSD KolourPaint.

Bah. Those are compatible and kolourpaint can't work without LGPL-kdelibs anyway.

--

-- 
David Faure, faure <at> kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).