headers
Dawit Alemayehu | 21 May 2012 08:21
Picon
Favicon

Re: Review Request: KWebKitPart - Fix Windows build

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105002/

src/sslinfodialog_p.h (Diff revision 1) 45 45
class KDE_EXPORT KSslInfoDialog : public KDialog { class KDE_IMPORT KSslInfoDialog : public KDialog {
You can simply remove the KDE_EXPORT. I should have really removed that before adding that header file. It is a private header file after all and is only there to make it possible to compile the code.

- Dawit


On May 20th, 2012, 10:07 p.m., Andrius da Costa Ribas wrote:

Review request for kdewin, kwebkitpart and Maks Orlovich.
By Andrius da Costa Ribas.

Updated May 20, 2012, 10:07 p.m.

Description

2 small points to fix Windows build of KWebKitPart. 1- We're always KDE_IMPORTing the KSslInfoDialog - symbol export/importing problems are often not detected on linux. 2- ifdef'd a X11 header (but probably it isn't needed at all).

Testing

Tested using MSVC 2010 on a Win7 64bit machine. Works pretty fine on Konqueror :)

Diffs

  • src/settings/webkit_filter.cpp (2fc48da)
  • src/sslinfodialog_p.h (de061e5)

View Diff

 
_______________________________________________
Kde-windows mailing list
Kde-windows@...
https://mail.kde.org/mailman/listinfo/kde-windows
Permalink | Reply |

Gmane