Donal K. Fellows | 5 Jul 13:22
Picon

Re: Updating Tktest suite - GSoC project

Ania Pawelczyk wrote:
> For the moment there're rfc for, briefly, my following problems:

These are just my comments on some of the issues. I hope they're helpful
to you...

>  > RFC scrollbar.test scrollbar-3.42

With lots of experience, a good test has the properties of being
isolated (so that it can be run without other tests getting in the way)
robust (so that it only tests what you want) and clear (so that when it
fails, it tells you enough for you to figure out what failed). And it's
*very* useful to be able to search on the test name; Tk's habit of doing
'test foo-5.[incr counter]' is something I'd like rid of even at the
cost of making things more verbose.

For the particular test that you were looking at there, it's probably
better to split that into two tests (different numbers, different
constraints) one which sets things up with testmetrics and the other of
which doesn't. If I've understood the issue right, that is. :-) (The
design of tests for the layout algorithms has got to be something of a
black art, since you've got to figure out how to avoid brokenness from
the environment and determine how to test what was intended instead of
conducting experiments on what is actually done... Tricky!)

>  > How to figure out in tcl if a definition was made during the 
> compilation? {(?) frame.test frame-2.5}

Firstly, that test *definitely* needs splitting so that it's two tests
with different constraints.

Curiously, that particular test needs to see something that's different
between msys builds and VC++/BC builds. Arguably, that's a configuration
bug. Something odd going on here, but I don't do a vast amount of Tk
maintenance these days...

Donal.

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08

Gmane