Peter Korsgaard | 10 Dec 13:35 2013

Re: [PATCH v5 1/1] ktap: new package

>>>>> "Anders" == Anders Darander <anders@...> writes:

 > Add ktap, a script-based dynamic tracing tool.
 > Signed-off-by: Anders Darander <anders@...>
 > ---

 > Changes v4 -> v5:
 > 	- Remove trailing whitespace that was added by mistake in
 > 	last version.

I just did a little test build with qemu_arm_versatile_defconfig:

/home/peko/source/buildroot/output/build/ktap-v0.3/interpreter/ktap.c:32:6: warning:
"CONFIG_EVENT_TRACING" is not defined [-Wundef]
/home/peko/source/buildroot/output/build/ktap-v0.3/interpreter/ktap.c:33:2: error: #error
"Please enable CONFIG_EVENT_TRACING before compile ktap"
/home/peko/source/buildroot/output/build/ktap-v0.3/interpreter/ktap.c:36:6: warning:
"CONFIG_PERF_EVENTS" is not defined [-Wundef]
/home/peko/source/buildroot/output/build/ktap-v0.3/interpreter/ktap.c:37:2: error: #error
"Please enable CONFIG_PERF_EVENTS before compile ktap"
make[3]: *** [/home/peko/source/buildroot/output/build/ktap-v0.3/interpreter/ktap.o] Error 1

It would be good if we could automatically enable the needed kernel
features when ktap is enabled, similar to how we do for E.G. devtmpfs.

But that can be done as a followup patch, so committed - Thanks.


Bye, Peter Korsgaard