6 Jan 2007 19:28
Re: Criteria cleanups
Cameron Brunner <cameron.brunner <at> gmail.com>
2007-01-06 18:28:09 GMT
2007-01-06 18:28:09 GMT
As anemic as those tests are it did find a typo for me, going thru more of criteria as i type, will commit something soonish. Cameron On 1/7/07, Cameron Brunner <cameron.brunner <at> gmail.com> wrote: > SEGV's trying to run the test suite :/ Will look into it more later > > BTW, is propel meant to support sqlite3 properly? is there a reason i > see sqlite2: dsn's? > > > Cameron > > On 1/6/07, Hans Lellelid <hans <at> velum.net> wrote: > > Thanks, Cameron! -- I know we do have some unit tests for Criteria, > > however incomplete they may be. Assuming those are all passing fine, > > please do commit the cleanups. > > > > Hans > > > > Cameron Brunner wrote: > > > ok, the Criteria::IN bug inspired me to do a bit of cleaning in > > > criteria, i got upto line 1000 odd just then before going my head > > > hurts so here is what iv done so far, anyone care to test and comment > > > etc. Everything from code style fixes to optimizations to making > > > things easier to read... > > > > > > > > > Cameron > > > > > > *snip*
RSS Feed