7 Jan 2007 04:16
Re: Criteria cleanups
Cameron Brunner <cameron.brunner <at> gmail.com>
2007-01-07 03:16:28 GMT
2007-01-07 03:16:28 GMT
I was more checking if the sql we send needed changes for sqlite3 instead of 2 to take advantage of any new features? Cameron On 1/7/07, David Zülke <dz <at> bitxtender.com> wrote: > the sqlite extension only supports sqlite2. with propel 1.3 we use > pdo, which is capable of both v2 and v3, IIRC > > > David > > > > > Am 06.01.2007 um 18:15 schrieb Cameron Brunner: > > > SEGV's trying to run the test suite :/ Will look into it more later > > > > BTW, is propel meant to support sqlite3 properly? is there a reason i > > see sqlite2: dsn's? > > > > > > Cameron > > > > On 1/6/07, Hans Lellelid <hans <at> velum.net> wrote: > >> Thanks, Cameron! -- I know we do have some unit tests for Criteria, > >> however incomplete they may be. Assuming those are all passing > >> fine, > >> please do commit the cleanups. > >> > >> Hans > >> > >> Cameron Brunner wrote: > >> > ok, the Criteria::IN bug inspired me to do a bit of cleaning in > >> > criteria, i got upto line 1000 odd just then before going my head > >> > hurts so here is what iv done so far, anyone care to test and > >> comment > >> > etc. Everything from code style fixes to optimizations to making > >> > things easier to read... > >> > > >> > > >> > Cameron
RSS Feed