Jonas Borgström | 27 Apr 14:35
Favicon

[Trac-dev] Re: t.e.o. unstable ?


Emmanuel Blot wrote:
> 
> I just encountered two major issues while browsing on t.e.o. within a
> single minute time frame:
> 
> 1/ When I clicked on "View Ticket/Custom Query" I got a Python
> traceback (plain text, no decoration) reporting that "layout.html" was
> missing. A simple refresh made the trouble go away.
> 2/ In the custom query report, I clicked on the ticket column header
> (to sort result by ticket number) and I hit a "500 Internal Error" web
> page. Again, a refresh made the trouble go away.
> 
> It happened at 23:47 CET (GMT+1), if someone wants to have a look at
> the log files.

I think I've figured out what caused this. When I inspected the fastcgi- 
processes on t.e.o I noticed that the "trac.log" file was opened several 
hundred times. It turns out that when we're reloading the environment we 
did not explicitly call the "close"-method on the logging handler. This 
is needed since the logging module keeps a reference to all active 
handlers for some reason.

This itself is of course a bug but shouldn't cause a "Too many open 
files" error unless the environment was excessively reloaded. The 
culprit seems to be the InterWikiMap component which calls 
"config.touch()" from the constructor which in turn triggers a 
environment reload. So a user visiting a wiki page containing an 
interwiki link would be enough to trigger a reload.

http://trac.edgewall.org/changeset/6892
http://trac.edgewall.org/changeset/6893

Hopefully these fixes will have some positive effect on the overall 
performance as well.

/ Jonas

PS
t.e.o is now r6893
DS

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Development" group.
To post to this group, send email to trac-dev <at> googlegroups.com
To unsubscribe from this group, send email to trac-dev-unsubscribe <at> googlegroups.com
For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---


Gmane