[Trac-dev] POST in wiki web handler

Hi,

is there any reason why the process_request method in WikiModulo does
nothing if method is 'POST' and action is not specified? The current
0.11.4 wiki/web_ui.py code looks like:

131	        if req.method == 'POST':
132	            if action == 'edit':
...
148	            elif action == 'diff':
149	                get_diff_options(req)
150	                req.redirect(req.href.wiki(versioned_page.name,
action='diff',
151	                                           old_version=old_version))
152	        elif action == 'delete':
...
160	        else:
161	            format = req.args.get('format')
162	            if format:
163	                Mimeview(self.env).send_converted(req, 'text/x-trac-wiki',
164	                                                  versioned_page.text,
165	                                                  format,
versioned_page.name)
166	            return self._render_view(req, versioned_page)

We are working in some special macros that show a form in the wiki and
do some processing, but we have to use GET method for those macro
forms, as using GET results in the request not being processed by the
Wiki module, so the macro is not run, and an error being thrown
(Response not started when writing headers).

Would it do any harm just to unindent line number 166, so if method is
POST, but action is unespecified, fallback to default processing?

Any comments welcome. Thanks very much!

-- 
Álvaro J. Iradier Muro
Departamento de Desarrollo
alvaro.iradier <at> polartech.es

Polar Technologies
T +34 976 527 952
F +34 976 466 125
www.polartech.es

Antes de imprimir este mensaje, por favor, compruebe que es verdaderamente
necesario. El medioambiente es cosa de todos.

AVISO LEGAL
Este mensaje, y en su caso, cualquier fichero anexo al mismo, puede contener
información confidencial, siendo para uso exclusivo del destinatario,
quedando prohibida su divulgación, copia o distribución a terceros sin la
autorización expresa del remitente. Si Vd. ha recibido este mensaje
erróneamente, se ruega lo notifique al remitente y proceda a su borrado.
Gracias por su colaboración.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Development" group.
To post to this group, send email to trac-dev <at> googlegroups.com
To unsubscribe from this group, send email to trac-dev+unsubscribe <at> googlegroups.com
For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---