[PATCH] idcin pts

headers Michael Niedermayer | 1 Mar 2008 02:36

On Fri, Feb 29, 2008 at 04:54:13PM -0800, Mike Melanson wrote:
> This patch gives the id CIN demuxer proper pts handling. This seems like a 
> mere nicety; however, attempting to transcode an id CIN file with 'ffmpeg' 
> goes into a nasty loop without this patch. No idea why. 'ffplay' still 
> plays an id CIN file correctly.

patch ok

btw in case you are curious why it causes problems, its because
90000 % 14 != 0 :)

The frame rate guessing code realizes that 14fps is the best matching but
its not good enough, thus the code leaves 90khz as the recommanded timebase
instead of recommanding 14hz.
ffmpeg then will encode at 90000 frames per second to preserve the wrong
timestamps your demuxer generates.
use of -r 14 (force 14fps) or -vsync 0 (variable "fps" / no frame dup/drop)
should have worked around it.

That reminds me that we need should add a flag to muxers signalling if they
can handle -vsync 0. That way it could be set to a more sane default
(patches welcome ...)

[...]
--

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope

Re: [PATCH] idcin pts