Huijun Yang | 18 Aug 17:32
Favicon

Polycom unit test clean up

Hello,

In the process of removing support of firmware 1.6 for Polycom, I found the following files are not used in the unit tests:

- expected-phone-2.0.cfg.xml
- expected-phone-2.1.2.cfg.xml
- expected-phone-2.2.0.cfg.xml
- expected-phone-2.2.2.cfg.xml

- expected-sip-2.0.cfg.xml
- expected-sip-2.1.2.cfg.xml
- expected-sip-2.2.0.cfg.xml
- expected-sip-2.2.2.cfg.xml
- expected-sip-3.0.0.cfg.xml

As for firmware versions beyond 2.0, they all have compatible format, I don't think we need to distinguish the versions anymore, at least at this point. Leaving those unused files only leads to confusion. I am suggesting to remove all those unused test files. Does anyone have objection?

Thanks
Huijun

<div>

<p>Hello,
</p>

<p>In the process of removing support of firmware 1.6 for Polycom, I found the following files are not used in the unit tests:</p>

<p>- expected-phone-2.0.cfg.xml

<br>- expected-phone-2.1.2.cfg.xml

<br>- expected-phone-2.2.0.cfg.xml

<br>- expected-phone-2.2.2.cfg.xml
</p>

<p>- expected-sip-2.0.cfg.xml

<br>- expected-sip-2.1.2.cfg.xml

<br>- expected-sip-2.2.0.cfg.xml

<br>- expected-sip-2.2.2.cfg.xml

<br>- expected-sip-3.0.0.cfg.xml
</p>

<p>As for firmware versions beyond 2.0, they all have compatible format, I don't think we need to distinguish the versions anymore, at least at this point. Leaving those unused files only leads to confusion. I am suggesting to remove all those unused test files. Does anyone have objection?</p>

<p>Thanks

<br>Huijun
</p>

</div>

Gmane