18 Jul 2012 07:09
[E-devel] [PATCH] elm_icon is disappeared when theme hook is called.
Seunggyun Kim <sgyun.kim <at> samsung.com>
2012-07-18 05:09:24 GMT
2012-07-18 05:09:24 GMT
Dear All,
[Current Issue]
- The elm_icon can be disappeared when theme hook is called.
You can see the problem in the below situation.
a) elementary_test -> Layout select
b) elementary_config -> Fonts(toolbar) -> select some font class, font,
style, size
c) Select "Apply" button
then two icons in title layout are disappeared.
[Main cause]
- when theme hook is called, internally _elm_image_smart_sizing_eval
function is called.
The function calculates icon's min, max size.
But min, max size is calculated only in case no_scale is true or
resize_down or resize_up is false.
If application isn't set no_scale or resize_down/up, minw and minh value
is just -1.
So when theme hooks is called then sizing_eval is called, icon's min size
is -1 and that is disappeared.
[Change Description]
- I just added evas_object_size_hint_min_get(obj, &minw, minh) in
_elm_image_smart_sizing_eval.
Patch is working well, but I don't think this is right solution because
that would break image(icon) min,max concept
Please review the attached patch.
Thanks.
Index: src/lib/elm_image.c
===================================================================
--- src/lib/elm_image.c (revision 74035)
+++ src/lib/elm_image.c (working copy)
<at> <at> -789,7 +789,8 <at> <at> _elm_image_smart_sizing_eval(Evas_Object *obj)
sd->scale = 1.0;
ELM_IMAGE_CLASS(ELM_WIDGET_DATA(sd)->api)->size_get(obj, &w, &h);
sd->scale = ts;
-
+ evas_object_size_hint_min_get(obj, &minw, &minh);
+
if (sd->no_scale)
{
maxw = minw = w;
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ enlightenment-devel mailing list enlightenment-devel <at> lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
RSS Feed