Alfredo Braunstein | 1 Mar 2004 10:03
Favicon

Re: [patch] encapsulate a font optimization

Lars Gullik Bjønnes wrote:

> Alfredo Braunstein <abraunst <at> lyx.org> writes:
> 
> | Lars Gullik Bjønnes wrote:
>>
>>> It looks like this is supposed to be a forward_iterator?
>>
> | Attached a second version... It aditionally fixes now a (it seems
> | long-standing) rebreaking bug that shows f.ex. in multiline paragraphs
> | in the Description layout (see for instance UG, section 3.1.2 with
> | current cvs, Amsart or Amsbook items).
>>
> | [About std::iterator... I've read a bit and it seems we are pretty much
> | stuck with output iterators for now? forward_iterator's operator* must
> | give a (non-const) reference]
> 
> You should still inherit from std::iterator so that more stl/std
> algorighmts can be used with this iterator.

Done.

> And IMHO operator-> should be implemented.

Done (are you sure it's a requirement?).

Result attached. Ok to go in?

Alfredo

Btw: Do you know a better place to put it than lyxtext.h/text.C ?
Attachment (fontiter5.diff): text/x-diff, 3899 bytes

Gmane