ediff frames not handled correctly

headers Károly Lőrentey | 12 Mar 2006 05:13

Dan Nicolaescu <dann <at> ics.uci.edu> writes:
> Try: 
>
> emacs -q
> M-x ediff RET SOMEFILE RET SOMEOTHERFILE RET
>
> now with the mouse on the small ediff control frame type ? twice.
> Normally the help frame be shown and then deleted, but it is not
> deleted. 

I finally tracked down this and some other (less critical)
ediff-related bugs:

	(1) `make-frame' could inadvertently change the current buffer
            due to an oversight in the `with-selected-frame' macro.
            This messed up the `ediff-control-frame' variable, so
            Ediff forgot about existing control frames, and kept
            recreating new ones.  This is the bug you describe.

        (2) The visibility declaration in (make-frame '((visibility . nil)))
	    did not immediately take effect due to a bug in CVS.  The
            frame was created visible, then made invisible later,
            resulting in annoying flicker.  I fixed this directly in
            CVS.

        (3) Ediff looked at `window-system' at load-time to choose
            between its single-frame and multi-frame layouts.  This
            fails when multiple terminal types are used in the same
            session.  I introduced the function
            `ediff-setup-windows-automatic' for dynamic window-system
            detection.

Note that the fix for (1) changes a macro, so you'll need to do a
bootstrap for it to take effect.

--

-- 
Károly

Re: ediff frames not handled correctly