codesite | 24 Oct 17:10 2010
Picon

Issue 152 in yasnippet: yas/ido-prompt doesn't work unless you have ido-mode enabled

Status: New
Owner: joaotavora
Labels: Type-Defect Priority-Medium

New issue 152 by richstyles: yas/ido-prompt doesn't work unless you have  
ido-mode enabled
http://code.google.com/p/yasnippet/issues/detail?id=152

What steps will reproduce the problem?
1. yas/ido-prompt doesn't activate if ido-mode isn't enabled
2.
3.

What is the expected output? What do you see instead?
expect yasnippet to use ido prompt

What version of the product are you using? On what operating system?
The latest from trunk

Please provide any additional information below.

Current code:
(defun yas/ido-prompt (prompt choices &optional display-fn)
   (when (and (featurep 'ido)
              ido-mode)
     (yas/completing-prompt prompt choices display-fn  
#'ido-completing-read)))

Should be:
(defun yas/ido-prompt (prompt choices &optional display-fn)
   (when (featurep 'ido)
     (yas/completing-prompt prompt choices display-fn  
#'ido-completing-read)))

Reason:
ido.el is bundled with emacs as of 22.  the function 'ido-completing-read  
doesn't require ido-mode to be active and can be used on its own.  Having  
ido-mode active might interfere with other extensions so having this  
requirement is a dealbreaker for some.  Plus, the proposed code doesn't  
change behavior for those that use it with ido-mode enabled.

--

-- 
You received this message because you are subscribed to the Google Groups "smart-snippet and YASnippet" group.
To post to this group, send email to smart-snippet@...
To unsubscribe from this group, send email to smart-snippet+unsubscribe@...
For more options, visit this group at http://groups.google.com/group/smart-snippet?hl=en.


Gmane