Wijnen, Bert (Bert | 3 Sep 2004 16:33
Picon
Favicon

AD review of: draft-ietf-adslmib-vdsl-ext-scm-05.txt

Mmm.. I finally started to review this one.

I find: 
    vdslLineSCMConfProfileBandId OBJECT-TYPE
        SYNTAX      Unsigned32 {        optionalBand (1),
                                        firstDownstreamBand (2),
                                        firstUpstreamBand (3),
                                        secondDownstreamBand (4),
                                        secondUpstreamBand (5),
                                        thirdDownstreamBand (6),
                                        thirdUpstreamBand (7) }
to cause a SYNTAX error with SMICng.
The reason is that enumerations should use INTEGER as base datatype.
See RFC2578 sect 7.1.1 2nd para:

   The INTEGER type (but not the Integer32 type) may also be used to
   represent integer-valued information as named-number enumerations.
   In this case, only those named-numbers so enumerated may be present
   as a value.  Note that although it is recommended that enumerated
   values start at 1 and be numbered contiguously, any valid value for
   Integer32 is allowed for an enumerated value and, further, enumerated
   values needn't be contiguously assigned.

When I fix that I run into the next one vdslLineSCMPhysBandId

Maybe the SCMBandId should be a TC ??

THen when I fix that, I run into syntax error
   vdslLineSCMConfProfileBandUsage OBJECT-TYPE
        SYNTAX       unsigned32
Unsigned32 needs to start with uppercase

Then when I fix that I get:
C:\bwijnen\smicng\work>smicng vdslscm.inc
E: f(vdslscm.mi2), (129,10) Index item "vdslLineSCMConfProfileBandId" may not ha
ve "read-write", "write-only", "read-create", or "accessible-for-notify" access

Can those syntax errors first be fixed please?

Thanks, Bert

Gmane