31 Mar 2012 03:50
Bug#653948: [SciPy-Dev] cephes_smirnov never returns on mips/sparc/...
Yaroslav Halchenko <lists <at> onerussian.com>
2012-03-31 01:50:56 GMT
2012-03-31 01:50:56 GMT
yeap -- that - if (n <= 0 || e < 0.0 || e > 1.0) + /* This comparison should assure returning NaN whenever + e is NaN itself. In original || form it would proceed */ + if (!(n > 0 && e >= 0.0 && e <= 1.0)) resolved the stalling issue and now I am getting the same (1.0, nan, nan) as on x86 ... sent pull request https://github.com/scipy/scipy/pull/187 patch is attached here as well so next I guess is to make it return sensible values for the .fit as it did before? ;) On Fri, 30 Mar 2012, Yaroslav Halchenko wrote: > well -- imho it should have not even got to that point if e is > NaN. Just started rebuilding with following patch: > - if (n <= 0 || e < 0.0 || e > 1.0) > + # This comparison should assure returning NaN whenever > + # e is NaN itself. In original || form it would proceed > + if !(n > 0 && e >= 0.0 && e <= 1.0) > return (NPY_NAN); -- -- =------------------------------------------------------------------= Keep in touch www.onerussian.com Yaroslav Halchenko www.ohloh.net/accounts/yarikoptic
RSS Feed