KaiGai Kohei | 25 Oct 04:19
Picon

Re: [2.6 patch] make jffs2_get_acl() static

Adrian Bunk wrote:
> jffs2_get_acl() can now become static again.
> 
> Signed-off-by: Adrian Bunk <bunk <at> kernel.org>

Acked-by: KaiGai Kohei <kaigai <at> ak.jp.nec.com>

> ---
> 
>  fs/jffs2/acl.c |    2 +-
>  fs/jffs2/acl.h |    2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> add2b887d64536f3fe978e62f0774292456f1ddb 
> diff --git a/fs/jffs2/acl.c b/fs/jffs2/acl.c
> index 9728614..b14e805 100644
> --- a/fs/jffs2/acl.c
> +++ b/fs/jffs2/acl.c
> @@ -176,7 +176,7 @@ static void jffs2_iset_acl(struct inode *inode, struct posix_acl **i_acl, struct
>  	spin_unlock(&inode->i_lock);
>  }
>  
> -struct posix_acl *jffs2_get_acl(struct inode *inode, int type)
> +static struct posix_acl *jffs2_get_acl(struct inode *inode, int type)
>  {
>  	struct jffs2_inode_info *f = JFFS2_INODE_INFO(inode);
>  	struct posix_acl *acl;
> diff --git a/fs/jffs2/acl.h b/fs/jffs2/acl.h
> index 76c6ebd..0bb7f00 100644
> --- a/fs/jffs2/acl.h
> +++ b/fs/jffs2/acl.h
> @@ -28,7 +28,6 @@ struct jffs2_acl_header {
>  
>  #define JFFS2_ACL_NOT_CACHED ((void *)-1)
>  
> -extern struct posix_acl *jffs2_get_acl(struct inode *inode, int type);
>  extern int jffs2_permission(struct inode *, int, struct nameidata *);
>  extern int jffs2_acl_chmod(struct inode *);
>  extern int jffs2_init_acl_pre(struct inode *, struct inode *, int *);
> @@ -40,7 +39,6 @@ extern struct xattr_handler jffs2_acl_default_xattr_handler;
>  
>  #else
>  
> -#define jffs2_get_acl(inode, type)		(NULL)
>  #define jffs2_permission			(NULL)
>  #define jffs2_acl_chmod(inode)			(0)
>  #define jffs2_init_acl_pre(dir_i,inode,mode)	(0)
> 
> 


Gmane