Re: [PATCH] acpiphp: Match the variable types for ia64

On Tue, Sep 09, 2008 at 11:22:45PM +0000, Chen, Justin wrote:
> The variable "sun" defined in acpiphp_glue.c as "unsigned long".  But the struct acpiphp_slot defines
the sun as u32 in acpiphp.h.
> 
> On the ia64, since the "unsigned long" is u64, the above mismatch may cause the problem if the _SUN returns
the value in 64 bits.
> 
> The following patch change the definition in acpiphp.h to match the type of sun with other places.

Does HP intend to have slot numbers larger than 4 billion?  The ACPI 3.0
spec is mute on how large the 'integer' returned from _SUN is --
presumably it can be 64 bit.  But if we're going to permit _SUN to
return 64-bit, we should make it u64 everywhere, not just 64-bit for
64-bit machines.

--

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."