Re: [PATCH] acpiphp: Match the variable types for ia64

On Thu, Sep 11, 2008 at 03:24:22AM +0000, Chen, Justin wrote:
>         acpiphp_slot->slot = slot;
> -       snprintf(slot->name, sizeof(slot->name), "%u", slot->acpi_slot->sun);
> +       snprintf(slot->name, sizeof(slot->name), "%lu",
> +               (unsigned long) slot->acpi_slot->sun);
> 

For printfs, cast to (unsigned long long) and use %llu.

>                 slot->device = device;
> -               slot->sun = sun;
> +               slot->sun = (u64) sun;

No ... the right thing to do here is make the local variable 'sun' a
u64.  adr ought to be a u32, not an unsigned long.

--

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."