Re: [PATCH 9/12] memcg allocate all page_cgroup at boot

KAMEZAWA Hiroyuki wrote:
> On Wed, 01 Oct 2008 09:33:53 +0530
> Balbir Singh <balbir <at> linux.vnet.ibm.com> wrote:
> 
>> Can we make this patch indepedent of the flags changes and push it in ASAP.
>>
> Need much work....Hmm..rewrite all again ? 
> 

I don't think you'll need to do a major rewrite? Will you? My concern is that
this patch does too much to be a single patch. Consider someone trying to do a
git-bisect to identify a problem? It is hard to review as well and I think the
patch that just removes struct page member can go in faster.

It will be easier to test/debug as well, we'll know if the problem is because of
new page_cgroup being outside struct page rather then guessing if it was the
atomic ops that caused the problem.

--

-- 
	Balbir