22 Jun 2012 00:04
Re: [net] ixgbe: simplify padding and length checks
David Miller <davem <at> davemloft.net>
2012-06-21 22:04:54 GMT
2012-06-21 22:04:54 GMT
From: Jeff Kirsher <jeffrey.t.kirsher <at> intel.com> Date: Thu, 21 Jun 2012 14:28:09 -0700 > On Thu, 2012-06-21 at 13:38 -0700, David Miller wrote: >> From: Jeff Kirsher <jeffrey.t.kirsher <at> intel.com> >> Date: Thu, 21 Jun 2012 05:15:10 -0700 >> >> > From: Stephen Hemminger <shemminger <at> vyatta.com> >> > >> > The check for length <= 0 is bogus because length is unsigned, and network >> > stack never sends zero length packets (unless it is totally broken). >> > >> > The check for really small packets can be optimized (using unlikely) >> > and calling skb_pad directly. >> > >> > Signed-off-by: Stephen Hemminger <shemminger <at> vyatta.com> >> > Tested-by: Phil Schmitt <phillip.j.schmitt <at> intel.com> >> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher <at> intel.com> >> >> Not really fixing anything and more of a cleanup, so maybe 'net-next' >> instead of 'net' for this guy instead? > > Yeah, net-next is fine. I just verified that the patch applies cleanly > to net-next as well. Great, applied, thanks.
RSS Feed