Re: [PATCH] mmci: call flush_dcache_page() outside of atomic kmap

On Sun, Jan 2, 2011 at 10:08 AM, Rabin Vincent <rabin <at> rab.in> wrote:
> On Sun, Jan 2, 2011 at 3:43 AM, Russell King - ARM Linux
> <linux <at> arm.linux.org.uk> wrote:
>> Err, hang on.  The sg iter API uses flush_kernel_dcache_page(), not
>> flush_dcache_page().  flush_kernel_dcache_page() is not expected to
>> touch userspace mappings.
>>
>> On ARM, we don't implement flush_kernel_dcache_page() because it's
>> not required (see commit f8b63c1.)  Essentially, because we now consider
>> freshly created page cache pages dirty, we always flush them before we
>> map them into userspace, so a call to flush_kernel_dcache_page() has
>> nothing to do.
>
> This email thread was never about the flush_kernel_dcache_page() in the
> sg_miter API.  It's about the flush_dcache_page() in MMCI.

This flush_dcache_page() can also be removed because of what you mention
above, right?