Re: possible bug on ppp_async

On Fri, 13 Jun 2008, Gustavo Fernando Padovan wrote:

>> The problem seems the ioctl TCSETS, with the patch (and on kernel
>> 2.6.23) it returns immediately, and on kernel 2.6.24 (without the
>> patch) it goes to tty_mode_ioctl().
>
> This patch also resolves the 'bug'. It intercepts TCSETS on
> switch(cmd) and return -ENOIOCTLCMD;
>
>
> --- a/drivers/net/ppp_async.c        2008-06-13 11:59:10.000000000 -0300
> +++ b/drivers/net/ppp_async.c     2008-06-13 11:58:34.000000000 -0300

No, that patch doesn't resolve the bug. That just avoids the bug. The bug 
is that the driver "goes silly" when passed a TCSETS cmd, and you need to 
reload the driver to make it sane again.

Aren't you curious as to why TCSETS calls are made, and why things go 
wrong when they are?
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html