Home
Reading
Searching
Subscribe
Sponsors
Statistics
Posting
Contact
Spam
Lists
Links
About
Hosting
Filtering
Features Download
Marketing
Archives
FAQ
Blog
 
Gmane
From: Mike Gabriel <mike.gabriel <at> das-netzwerkteam.de>
Subject: Bug#81: get rid of remnant html tags in client<->broker communications
Newsgroups: gmane.linux.terminal-server.x2go.devel
Date: Friday 7th December 2012 08:06:00 UTC (over 3 years ago)
Package: x2goclient
Severity: normal
Version: 3.99.3.1-HEAD
Tags: patch confirmed

Hi Alex,

I have taken a closer look at the httpbrokerclient.cpp code in  
x2goclient. Most replies from the httpbroker are compliant with a  
text/plain content type. This is good IMHO.

However, in HttpBrokerClient::createIniFile x2goclient expects 
html tags as line breaks. If these
tags are missing, the session profile won't get recognized by x2goclient. With the current developmental code in x2gobroker.git, I try to implement the current broker API with no html elements at all, so I'd be happy if these last required
s could be made unnecessary. Currently, as a list of session profiles the httpbroker client code in x2goclient expects some broker output like this: """ START_USER_SESSIONS
[b00830a9-aec4-4e9e-88f8-ddbffeb1c8ea]defsndport=1
sndport=4713
xinerama=1
variant=
useiconv=0
iconvfrom=UTF-8
height=600
usekbd=1
applications=TERMINAL,WWWBROWSER,MAILCLIENT,OFFICE
host=localhost
export=
user=
fstunnel=1
quality=9
sshport=22
sound=1
fullscreen=0
rootless=0
layout=
name=LOCALHOST
sshproxyport=22
soundsystem=pulse
speed=2
iconvto=UTF-8
soundtunnel=1
useexports=1
width=800
command=KDE
multidisp=0
print=1
setdpi=0
type=auto
dpi=96
pack=16m-jpeg
END_USER_SESSIONS
""" So, I am quite keen on x2goclient being able to _also_ handle broker output that looks like this, instead: """ [47af8619-d619-43de-bf00-2c30c47772d1] defsndport=1 sndport=4713 xinerama=1 variant= useiconv=0 iconvfrom=UTF-8 height=600 usekbd=1 applications=TERMINAL,WWWBROWSER,MAILCLIENT,OFFICE host=localhost export= user= fstunnel=1 quality=9 sshport=22 sound=1 fullscreen=0 rootless=0 layout= name=LOCALHOST sshproxyport=22 soundsystem=pulse speed=2 iconvto=UTF-8 soundtunnel=1 useexports=1 width=800 command=KDE multidisp=0 print=1 setdpi=0 type=auto dpi=96 pack=16m-jpeg END_USER_SESSIONS """ Attached to this post you find a patch against httpbrokerclient.* that makes x2goclient understand both variants of httpbroker output (IMHO). Can you please cross-check if that patch keeps x2goclient working with all other broker implementations that are currently deployed at your customers' sites? Greets, Mike -- DAS-NETZWERKTEAM mike gabriel, rothenstein 5, 24214 neudorf-bornstein fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: [email protected], http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
 
CD: 23ms