Re: [PATCH 0/1] UBUNTU: [Hardy SRU][SAUCE] Add signatures to airprime driver to support newer Novatel devices

Brad Figg wrote:
> Stefan Bader wrote:
>> Brad Figg wrote:
>>> SRU Justification:
>>>
>>> Impact: Addition of new device signatures should have no impact to 
>>> existing
>>> devices.
>>> Fix: Simple addition of two device signatures to the device id table.
>>>
>>> Testcase: See bug report
>>>
>>> Please pull from :
>>>     git://kernel.ubuntu.com/bradf/ubuntu-hardy master
>>>
>>> Bug: #365291
>>>
>>> Brad Figg (1):
>>>   UBUNTU: [Hardy SRU] Add signatures to airprime driver to support
>>>     newer Novatel devices
>>>
>>>  drivers/usb/serial/airprime.c |    2 ++
>>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>>
>> Are you positive that those should go to airprime? Most of the other 
>> Novatel are in option.c
>>
> 
> I was following what was in the bug report which seemed to indicate it
> worked for the submitter. I also looked at airprime.c and saw that
> it had the signatures for the U760 and this is adding a newer U760.
> 
> Brad
> 

Stefan - I think it's correct to add new the USB IDs to
drivers/usb/serial/airprime.c. After all, there is already an existing
Novatel device supported by this driver, user tests indicate its a
functional patch, and its not likely gonna cause rebase conflicts (this
_is_ Hardy).

rtg
--

-- 
Tim Gardner tim.gardner <at> canonical.com