Re: [Jaunty SRU] atkbd: enable send key release events for Samsung Q45 notebook

On Fri, May 01, 2009 at 08:26:55AM +0100, Colin King wrote:
> LP#347623
> 
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/347623
> 
> SRU Justification:
> 
> Impact: The Samsung Q45 does not send key release events for several
> Fn-keys, for example, the LCD brightness adjustment Fn-Keys.
> 
> Fix: Attached patch from LaunchPad user pittipatti, based on the NC10
> keycodes.
> 
> Testcase: Without the patch, the Fn-Keys don't work, with the patch,
> they are enabled. Tested by pittipatti.
> 
> 
> -- 
> Colin King   <colin.king <at> canonical.com>
> "Me transmitte sursum, caledoni" 

> From e7fe244488b449b5babad05aa65c448f817cea13 Mon Sep 17 00:00:00 2001
> From: Colin Ian King <colin.king <at> canonical.com>
> Date: Tue, 28 Apr 2009 10:45:38 +0100
> Subject: [PATCH] UBUNTU: SAUCE: atkbd: enable send key release events for Samsung Q45 notebook
> 
> OriginalLocation: http://launchpadlibrarian.net/24292789/atkbd-samsung-q45.patch
> Bug: #347623
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/347623
> 
> Enable send key release events for Fn-keys for
> Samsung Q45 notebook.  This enables the LCD brightness
> to be adjusted via the Fn-keys
> 
> Signed-off-by: Colin Ian King <colin.king <at> canonical.com>
> ---
>  drivers/input/keyboard/atkbd.c |   11 ++++++++++-
>  1 files changed, 10 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index 4a4eb12..87eaff6 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
>  <at>  <at>  -901,7 +901,7  <at>  <at>  static void atkbd_hp_zv6100_keymap_fixup(struct atkbd *atkbd)
>  }
>  
>  /*
> - * Samsung NC10, NC20 with Fn+F? key release not working
> + * Samsung NC10, NC20, Q45 with Fn+F? key release not working
>   */
>  static void atkbd_samsung_keymap_fixup(struct atkbd *atkbd)
>  {
>  <at>  <at>  -1579,6 +1579,15  <at>  <at>  static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
>  		.driver_data = atkbd_samsung_keymap_fixup,
>  	},
>  	{
> +		.ident = "Samsung Q45",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "SQ45S70S"),
> +		},
> +		.callback = atkbd_setup_fixup,
> +		.driver_data = atkbd_samsung_keymap_fixup,
> +	},
> +	{
>  		.ident = "Znote 6615WD",
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "Zepto"),
> -- 
> 1.6.0.4
> 

ACK

--

-- 
----------------------------------------------------------------------
Amit Kucheria, Kernel Engineer || amit <at> canonical.com
----------------------------------------------------------------------