Andrew J. Schorr | 1 Nov 2004 15:13
Favicon

[quagga-dev 1755] Re: daemon writes to vtysh need to be buffered or forked

On Mon, Nov 01, 2004 at 11:25:29AM +0200, Hasso Tepper wrote:
> I'm going to look at it in the evening, but for now I must say - really good 
> work. I'm impressed. Preliminary performance test with bgpd with full feed:
> 
> Before applying patch
> *********************
> time vtysh -c "sho ip bgp" > /dev/null
>    25.91s real     1.46s user    21.47s system
> 
> After applying patch
> ********************
> time vtysh -c "sho ip bgp" > /dev/null
>     5.27s real     0.13s user     0.37s system

Of course, the real question is whether the output is the same. :-)
But I'm not surprised by the speedup, the old code used to make a
write system call for every line of output, that was very
inefficient.

-Andy


Gmane