[quagga-dev 4547] Re: [PATCH] [RESEND] route-map, prefix list, and source setting support for zebra

On Thu, Jan 04, 2007 at 11:09:27AM +0100, Piotr Chytla wrote:
> Interesting patch , I've done some testing and I think some usefull commands
> are missing in your patch.  For example when I set route-map for ip
> protocol, those command are not saved in config file, second thing is 
> lack of command that shows current status of 'ip protocol'. 
> I've made two patches that adds write support for 'ip protocol' and 
> command show ip protocol - Of course if you are interested.
> 

There is also missing VTYSH_ZEBRA in define VTYSH_RMAP(vtysh/vtysh.h),
that cause something like bellow , on all commands in 'route-map'.

triss|vtysh# conf t
triss|vtysh(config)# route-map foo permit 10
triss|vtysh(config-route-map)# match interface eth0
%% [ZEBRA] Unknown command: match interface eth0

Patch attached.

/pch

-- 
Dyslexia bug unpatched since 1977 ...
exploit has been leaked to the underground.

diff --git a/vtysh/vtysh.h b/vtysh/vtysh.h
index dd2bcbd..3ed0dd3 100644
--- a/vtysh/vtysh.h
+++ b/vtysh/vtysh.h
 <at>  <at>  -30,7 +30,7  <at>  <at>  #define VTYSH_OSPF6D 0x10
 #define VTYSH_BGPD   0x20
 #define VTYSH_ISISD  0x40
 #define VTYSH_ALL	  VTYSH_ZEBRA|VTYSH_RIPD|VTYSH_RIPNGD|VTYSH_OSPFD|VTYSH_OSPF6D|VTYSH_BGPD|VTYSH_ISISD
-#define VTYSH_RMAP	  VTYSH_RIPD|VTYSH_RIPNGD|VTYSH_OSPFD|VTYSH_OSPF6D|VTYSH_BGPD
+#define VTYSH_RMAP	  VTYSH_ZEBRA|VTYSH_RIPD|VTYSH_RIPNGD|VTYSH_OSPFD|VTYSH_OSPF6D|VTYSH_BGPD
 #define VTYSH_INTERFACE	  VTYSH_ZEBRA|VTYSH_RIPD|VTYSH_RIPNGD|VTYSH_OSPFD|VTYSH_OSPF6D|VTYSH_ISISD

 /* vtysh local configuration file. */

diff --git a/vtysh/vtysh.h b/vtysh/vtysh.h
index dd2bcbd..3ed0dd3 100644
--- a/vtysh/vtysh.h
+++ b/vtysh/vtysh.h
 <at>  <at>  -30,7 +30,7  <at>  <at>  #define VTYSH_OSPF6D 0x10
 #define VTYSH_BGPD   0x20
 #define VTYSH_ISISD  0x40
 #define VTYSH_ALL	  VTYSH_ZEBRA|VTYSH_RIPD|VTYSH_RIPNGD|VTYSH_OSPFD|VTYSH_OSPF6D|VTYSH_BGPD|VTYSH_ISISD
-#define VTYSH_RMAP	  VTYSH_RIPD|VTYSH_RIPNGD|VTYSH_OSPFD|VTYSH_OSPF6D|VTYSH_BGPD
+#define VTYSH_RMAP	  VTYSH_ZEBRA|VTYSH_RIPD|VTYSH_RIPNGD|VTYSH_OSPFD|VTYSH_OSPF6D|VTYSH_BGPD
 #define VTYSH_INTERFACE	  VTYSH_ZEBRA|VTYSH_RIPD|VTYSH_RIPNGD|VTYSH_OSPFD|VTYSH_OSPF6D|VTYSH_ISISD

 /* vtysh local configuration file. */