25 May 2012 12:22
[quagga-dev 9383] [PATCH 2/4] smux: drop findVar element from trap object struct
Vincent Bernat <bernat <at> luffy.cx>
2012-05-25 10:22:02 GMT
2012-05-25 10:22:02 GMT
This element was not unused.
---
bgpd/bgp_snmp.c | 4 ++--
lib/smux.h | 3 +--
ospfd/ospf_snmp.c | 32 ++++++++++++++++----------------
3 files changed, 19 insertions(+), 20 deletions(-)
diff --git a/bgpd/bgp_snmp.c b/bgpd/bgp_snmp.c
index a995ff6..73406d5 100644
--- a/bgpd/bgp_snmp.c
+++ b/bgpd/bgp_snmp.c
<at> <at> -833,8 +833,8 <at> <at> bgp4PathAttrTable (struct variable *v, oid name[], size_t *length,
/* BGP Traps. */
struct trap_object bgpTrapList[] =
{
- {bgpPeerTable, 3, {3, 1, BGPPEERLASTERROR}},
- {bgpPeerTable, 3, {3, 1, BGPPEERSTATE}}
+ {3, {3, 1, BGPPEERLASTERROR}},
+ {3, {3, 1, BGPPEERSTATE}}
};
void
diff --git a/lib/smux.h b/lib/smux.h
index 78460e6..b7d5096 100644
--- a/lib/smux.h
+++ b/lib/smux.h
<at> <at> -47,8 +47,7 <at> <at>
struct trap_object
{
- FindVarMethod *findVar;
- int namelen;
+ int namelen; /* Negative if the object is not indexed */
oid name[MAX_OID_LEN];
};
diff --git a/ospfd/ospf_snmp.c b/ospfd/ospf_snmp.c
index 409153b..b2d5686 100644
--- a/ospfd/ospf_snmp.c
+++ b/ospfd/ospf_snmp.c
<at> <at> -2568,35 +2568,35 <at> <at> ospfAreaAggregateEntry (struct variable *v, oid *name, size_t *length,
struct trap_object ospfNbrTrapList[] =
{
- {ospfGeneralGroup, -2, {1, OSPFROUTERID}},
- {ospfNbrEntry, 3, {10, 1, OSPFNBRIPADDR}},
- {ospfNbrEntry, 3, {10, 1, OSPFNBRRTRID}},
- {ospfNbrEntry, 3, {10, 1, OSPFNBRSTATE}}
+ {-2, {1, OSPFROUTERID}},
+ {3, {10, 1, OSPFNBRIPADDR}},
+ {3, {10, 1, OSPFNBRRTRID}},
+ {3, {10, 1, OSPFNBRSTATE}}
};
struct trap_object ospfVirtNbrTrapList[] =
{
- {ospfGeneralGroup, -2, {1, 1}},
- {ospfVirtNbrEntry, 3, {11, 1, OSPFVIRTNBRAREA}},
- {ospfVirtNbrEntry, 3, {11, 1, OSPFVIRTNBRRTRID}},
- {ospfVirtNbrEntry, 3, {11, 1, OSPFVIRTNBRSTATE}}
+ {-2, {1, 1}},
+ {3, {11, 1, OSPFVIRTNBRAREA}},
+ {3, {11, 1, OSPFVIRTNBRRTRID}},
+ {3, {11, 1, OSPFVIRTNBRSTATE}}
};
struct trap_object ospfIfTrapList[] =
{
- {ospfGeneralGroup, -2, {1, OSPFROUTERID}},
- {ospfIfEntry, 3, {7, 1, OSPFIFIPADDRESS}},
- {ospfIfEntry, 3, {7, 1, OSPFADDRESSLESSIF}},
- {ospfIfEntry, 3, {7, 1, OSPFIFSTATE}}
+ {-2, {1, OSPFROUTERID}},
+ {3, {7, 1, OSPFIFIPADDRESS}},
+ {3, {7, 1, OSPFADDRESSLESSIF}},
+ {3, {7, 1, OSPFIFSTATE}}
};
struct trap_object ospfVirtIfTrapList[] =
{
- {ospfGeneralGroup, -2, {1, OSPFROUTERID}},
- {ospfVirtIfEntry, 3, {9, 1, OSPFVIRTIFAREAID}},
- {ospfVirtIfEntry, 3, {9, 1, OSPFVIRTIFNEIGHBOR}},
- {ospfVirtIfEntry, 3, {9, 1, OSPFVIRTIFSTATE}}
+ {-2, {1, OSPFROUTERID}},
+ {3, {9, 1, OSPFVIRTIFAREAID}},
+ {3, {9, 1, OSPFVIRTIFNEIGHBOR}},
+ {3, {9, 1, OSPFVIRTIFSTATE}}
};
void
--
--
1.7.10
RSS Feed