Re: [PATCH] prompt_yn() accepts only keys from prompt_keys

On 2005-03-08 16:00:52 +0100, Urs Janßen wrote:
> In <20050307234513.GA23580 <at> vorlon.ping.de>, Michael Bienia wrote:
> > Here are the changes to keymap.sample and tin.5 to document this
> > possibility. I've also merged the other duplicate keynames this way and
> > tried to stay compatible with older keymap files.
> > "PageDown3" wasn't merged with "PageDown" because of the seperate
> > handling in page.c.
> 
> keymap.c still looks for some obsolete keynames, e.g.:
> ConfigSelect2, Down2, GroupReadBasenote2, PageDown2, PageNextThd2, PageUp2
> PageUp3, Postponed2, PostPost2, PostPost3, PostSend2
> SelectEnterNextUnreadGrp2, SelectMarkGrpUnread2, SelectReadGrp2
> ThreadReadArt2, Up2
> 
> IMHO we should remove them from the normal code, but handle them in
> the RC_UPGRADE case (like it's done for the tinrc in
> config.c:read_config_file() via rc_update()). on exit we should
> 'overwrite' the old keymapfile with the updated new one.

Updating the keymap-file from within tin is tricky. The hard part is to
write out the keymap file. For some keys it is hard to tell the keynames
they come from. For example the key to jump to the first page in the
info pager: once it can be set through the global "FirstPage" and a
second time through "HelpFirstPage2" but in both cases the key gets
associated with GLOBAL_FIRST_PAGE.
If tin has to write a keymap file it has to decide if a key for
GLOBAL_FIRST_PAGE came from "FirstPage" or "HelpFirstPage2".

IMHO a solution to upgrade the keymap file though a perl script is much
easier and less error prone.

Michael