Re: Update of devel/py-twisted to 11.0.0

Hello Sofian,

Thanks for working on this, python <at>  definitely need more power!

Please see the reply inline.

On Wed, Sep 7, 2011 at 04:57, Sofian Brabez <sbz <at> freebsd.org> wrote:
> Hi python <at> ,
>
> This afternoon, I've merged my initial update to the twisted related ports with
> the patch of lwhsu <at>  [1]. My patch is there [2].
>
> My patch make happy portlint, add LICENSE in each twisted ports and add new
> OPTIONS for twistedPair port.

And please also add pair_DEPENDS in bsd.python.mk, that is around line 641.

> Please lwhsu <at>  notice than all twisted ports are sharing the
> ${PYTHON_SITELIBDIR}/twisted/plugins folder that's why I've replaced the  <at> dirrm
> by a  <at> dirrmtry in pkg-plist.

Thanks for reminding me this, I think we have

     <at> dirrm %%PYTHON_SITELIBDIR%%/twisted/plugins in

in devel/py-twistedCore/pkg-plist, and all other twisted ports depends
on twistedCore, so we probably don't need to have  <at> dirrm nor  <at> dirrmtry
in other ports.
They sneaked in my patch because I forget this, so just removing them
is fine. (I was planning getting maintainer's approval on general idea
then doing a more substantial patch.)
Using  <at> dirrmtry is fine, too.

> I would like to have your approbation to commit it, and sent it to my mentors
> for their approbations, I start working on this one because I took the pr
> ports/155570 but lwhsu <at>  inform me about ports/159954 on #freebsd-python.
>
> Below the tinderbox build logs:
>
> http://regis.goodking.org/tb/index.php?action=list_buildports&build=7-sbz&search_port_name=twisted&Go=Go
> http://regis.goodking.org/tb/index.php?action=list_buildports&build=8-sbz&search_port_name=twisted&Go=Go
> http://regis.goodking.org/tb/index.php?action=list_buildports&build=9-sbz&search_port_name=twisted&Go=Go

All looks good, and I also tested building all other ports depends on
twisted, all are fine.  Is anybody aware non-backward-compatible
change?

Another thing, I found there is no twisted 11.0.0 distfiles in
http://tmrc.mit.edu/mirror/twisted/, that's why I removed them from
MASTER_SITES, could you check it again?

Please consider my suggestions, thanks!

> Regards
>
> [1] http://people.freebsd.org/~lwhsu/twisted-11.0.0.diff
> [2] http://people.freebsd.org/~sbz/twisted-11.0.0.diff
>
> --
> Sofian Brabez
>

--

-- 
Li-Wen Hsu
http://lwhsu.org