David Hyatt | 1 Nov 2010 18:00
Picon
Favicon

Re: Coding style change - Indentation of forward declarations in headers

Yeah I agree with Peter.  I think blank lines after { and before } would improve the readability of the 2nd example even without indentation.

namespace WebCore {

class AuthenticationChallenge;
class CachedFrame;
class HistoryItem;
class ProtectionSpace;
class ResourceLoader;
class ResourceRequest;

}

This doesn't seem worth making a special case for to me.

dave

On Nov 1, 2010, at 11:49 AM, Peter Kasting wrote:

On Mon, Nov 1, 2010 at 9:40 AM, Brady Eidson <beidson <at> apple.com> wrote:
I think this pattern increases readability of forward declarations in headers and we should change the style guidelines to specify its continued use.

Thoughts?

I don't find either one significantly better than the other, personally.

PK 
_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

_______________________________________________
webkit-dev mailing list
webkit-dev <at> lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Gmane